Skip to content

Conversation

khink
Copy link
Contributor

@khink khink commented Apr 16, 2014

A branch with a DateColumn.

I first started using https://github.com/collective/Products.DataGridField/blob/lepri-datetime-column/Products/DataGridField/ but couldn't get that to work. (That branch requires collective.js.jqueryui, which is a big overhead and messed up my JS setup. I was too lazy to figure it out.) I did use some of the code, though.

This branch uses only plone.app.jquerytools (1.2 or higher), and was tested in a Plone 4.0 instance.

@mauritsvanrees
Copy link
Member

Thanks for working on this! A few remarks.

Can you add a date column to one of the example types in the examples directory? Then it gets easier to test manually (import the "DataGridField (Example DGF content types)" profile in portal_setup) and it gets at least a bit of automatic testing. Well, I have now done that myself. :-) Feel free to change.

Adding tests specifically for this column type would be cool, but don't lose sleep on it. The test setup is a bit ancient...

Here is a screenshot to clarify a few following comments:

schermafbeelding 2014-04-29 om 18 54 07

The current date gets printed as a help text, which seems unneeded.

When I select a date, save it, edit it again, and click on the date, the popup should show the stored date instead of today.

An existing date column is too wide: it falls over the + sign. This is in Firefox.

@keul
Copy link
Member

keul commented Apr 30, 2014

This is really cool, I was not aware of the jQuery tools feature about Date picker! I will remove DateColum from collective.datagridcolumns (it's based on jQueryUI and, as you say, is a pain)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants