Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard: add missing control btns to uppercase #34344

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

ugtthis
Copy link
Contributor

@ugtthis ugtthis commented Jan 9, 2025

When toggling between lowercase and uppercase the control buttons / and - don't appear. These control buttons are still useful for branch names and wifi for both lowercase and uppercase.

  • Bigger space button for uppercase keyboard is less useful than having the same control btns as lowercase
  • / and - added to uppercase keyboard
  • Added the keyboard_uppercase to show in ui_preview.yaml with PR CI: Add missing uppercase_keyboard UI view #34347

Current UI

no-slash-when-caps

Proposed UI

added-slash

@github-actions github-actions bot added the ui label Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

UI Preview

All Screenshots

@jyoung8607
Copy link
Collaborator

That's a good catch! As part of the fix, can you go ahead and add the missing view to the GH action preview?

@ugtthis
Copy link
Contributor Author

ugtthis commented Jan 9, 2025

I have the PR draft up but I still need to test on my fork to see if the new UI view works


PR is ready with the added keyboard view

@ugtthis ugtthis marked this pull request as draft January 10, 2025 00:28
@ugtthis ugtthis marked this pull request as ready for review January 10, 2025 05:15
@sshane sshane merged commit 7195156 into commaai:master Jan 13, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants