-
Notifications
You must be signed in to change notification settings - Fork 139
feat: Enable Arrow to convert nullable StructArray to RecordBatch #1635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1635 +/- ##
==========================================
- Coverage 84.16% 84.16% -0.01%
==========================================
Files 123 123
Lines 34179 34214 +35
Branches 34179 34214 +35
==========================================
+ Hits 28767 28796 +29
Misses 4021 4021
- Partials 1391 1397 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
95f6a3d to
f126545
Compare
f126545 to
b3b511b
Compare
dengsh12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, amazing to learn the Arrow's JSON reader does this automatically
nicklan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for looking into this!
🥞 Stacked PR
Use this link to review incremental changes.
What changes are proposed in this pull request?
Change apply_schema to propagate top-level struct nulls to child columns instead of erroring
How was this change tested?
Edited unit tests
Added unit test to show new behavior