refactor: consolidate nullable stat transforms #1636
Merged
+23
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
breaking-change
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1636 +/- ##
==========================================
- Coverage 84.16% 84.15% -0.01%
==========================================
Files 123 123
Lines 34214 34180 -34
Branches 34214 34180 -34
==========================================
- Hits 28796 28764 -32
Misses 4021 4021
+ Partials 1397 1395 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DrakeLin
changed the title
DrakeLin
force-pushed
the
stack/nullable-transform
branch
from
10ecc86 to
318087c
Compare
DrakeLin
force-pushed
the
stack/nullable-transform
branch
from
318087c to
c8c1f6b
Compare
DrakeLin
force-pushed
the
stack/nullable-transform
branch
from
c8c1f6b to
0568a9b
Compare
nicklan
approved these changes
Jan 21, 2026
github-actions
bot
removed
the
breaking-change
DrakeLin
added a commit
that referenced
this pull request
Jan 21, 2026
) ## 🥞 Stacked PR Use this [link](https://github.com/delta-io/delta-kernel-rs/pull/1635/files) to review incremental changes. - [**stack/propagate-nulls**](#1635) [[Files changed](https://github.com/delta-io/delta-kernel-rs/pull/1635/files)] - [stack/nullable-transform](#1636) [[Files changed](https://github.com/delta-io/delta-kernel-rs/pull/1636/files/b3b511b3b11aada328cf613b92bc851b3095efaf..0568a9b8b1ffaa6d6128fd05abff3f6820e1fd76)] - [stack/has_compatible_parsed_stats](#1638) [[Files changed](https://github.com/delta-io/delta-kernel-rs/pull/1638/files/0568a9b8b1ffaa6d6128fd05abff3f6820e1fd76..f840878ae0ca1db97d51512dca0ba7dff1b8371e)] - [stack/read-parsed-stats](#1639) [[Files changed](https://github.com/delta-io/delta-kernel-rs/pull/1639/files/f840878ae0ca1db97d51512dca0ba7dff1b8371e..f0e4680cab79fb7d6878cda709fc55119449d680)] --------- ## What changes are proposed in this pull request? Change apply_schema to propagate top-level struct nulls to child columns instead of erroring - Remove the error check for top-level nulls in apply_schema - Document that child columns are expected to already have nulls propagated (Arrow's JSON reader does this automatically, and parquet data goes through fix_nested_null_masks) - Add comprehensive test case test_apply_schema_handles_top_level_null ## How was this change tested? Edited unit tests Added unit test to show new behavior
DrakeLin
force-pushed
the
stack/nullable-transform
branch
from
4e8fd3c to
16e428c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
What changes are proposed in this pull request?
This PR consolidates duplicated NullableStatsTransform and NullCountStatsTransform implementations into a single shared location.
How was this change tested?