-
Notifications
You must be signed in to change notification settings - Fork 139
feat: integrate parsed stats with data skipping #1639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DrakeLin
wants to merge
3
commits into
delta-io:main
Choose a base branch
from
DrakeLin:stack/read-parsed-stats
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+645
−171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 20, 2026
2518e9c to
67edd53
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1639 +/- ##
==========================================
+ Coverage 84.65% 84.70% +0.05%
==========================================
Files 123 123
Lines 34109 34328 +219
Branches 34109 34328 +219
==========================================
+ Hits 28875 29079 +204
- Misses 3905 3919 +14
- Partials 1329 1330 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
28acc14 to
f0018a5
Compare
f0018a5 to
a2ebc6b
Compare
a2ebc6b to
f0e4680
Compare
DrakeLin
added a commit
that referenced
this pull request
Jan 21, 2026
) ## 🥞 Stacked PR Use this [link](https://github.com/delta-io/delta-kernel-rs/pull/1635/files) to review incremental changes. - [**stack/propagate-nulls**](#1635) [[Files changed](https://github.com/delta-io/delta-kernel-rs/pull/1635/files)] - [stack/nullable-transform](#1636) [[Files changed](https://github.com/delta-io/delta-kernel-rs/pull/1636/files/b3b511b3b11aada328cf613b92bc851b3095efaf..0568a9b8b1ffaa6d6128fd05abff3f6820e1fd76)] - [stack/has_compatible_parsed_stats](#1638) [[Files changed](https://github.com/delta-io/delta-kernel-rs/pull/1638/files/0568a9b8b1ffaa6d6128fd05abff3f6820e1fd76..f840878ae0ca1db97d51512dca0ba7dff1b8371e)] - [stack/read-parsed-stats](#1639) [[Files changed](https://github.com/delta-io/delta-kernel-rs/pull/1639/files/f840878ae0ca1db97d51512dca0ba7dff1b8371e..f0e4680cab79fb7d6878cda709fc55119449d680)] --------- ## What changes are proposed in this pull request? Change apply_schema to propagate top-level struct nulls to child columns instead of erroring - Remove the error check for top-level nulls in apply_schema - Document that child columns are expected to already have nulls propagated (Arrow's JSON reader does this automatically, and parquet data goes through fix_nested_null_masks) - Add comprehensive test case test_apply_schema_handles_top_level_null ## How was this change tested? Edited unit tests Added unit test to show new behavior
f0e4680 to
dff4b57
Compare
DrakeLin
added a commit
that referenced
this pull request
Jan 21, 2026
## 🥞 Stacked PR Use this [link](https://github.com/delta-io/delta-kernel-rs/pull/1636/files) to review incremental changes. - [**stack/nullable-transform**](#1636) [[Files changed](https://github.com/delta-io/delta-kernel-rs/pull/1636/files)] - [stack/has_compatible_parsed_stats](#1638) [[Files changed](https://github.com/delta-io/delta-kernel-rs/pull/1638/files/16e428c2fe7a256de0ddb852a11475d7ea131769..a9b9b115b2dd7289447b94bf7646872ee049fec6)] - [stack/read-parsed-stats](#1639) [[Files changed](https://github.com/delta-io/delta-kernel-rs/pull/1639/files/a9b9b115b2dd7289447b94bf7646872ee049fec6..dff4b57e26b9819a18b29d85d2860283c8ad04c0)] --------- ## What changes are proposed in this pull request? This PR consolidates duplicated NullableStatsTransform and NullCountStatsTransform implementations into a single shared location. <!-- **Uncomment** this section if there are any changes affecting public APIs. Else, **delete** this section. ### This PR affects the following public APIs If there are breaking changes, please ensure the `breaking-changes` label gets added by CI, and describe why the changes are needed. Note that _new_ public APIs are not considered breaking. --> ## How was this change tested?
5387120 to
0e03b17
Compare
5d21016 to
5bbf538
Compare
5bbf538 to
6b96787
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
What changes are proposed in this pull request?
This PR enables reading pre-parsed statistics (stats_parsed) directly from checkpoint files for data skipping, avoiding JSON parsing overhead.
DataSkippingFilter Updates
How was this change tested?
Add new test table tests/data/parsed-stats/ with:
Integration Tests