Skip to content

Verilog: typechecking for remaining binary expressions #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tautschnig merged 2 commits into from
Nov 16, 2024
Merged

Verilog: typechecking for remaining binary expressions #821

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c029fa
SVA: typechecking for sequence concatenation
kroening Nov 16, 2024
a9e8922
Verilog: typechecking for remaining binary expressions
kroening Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 67 additions & 22 deletions src/verilog/verilog_typecheck_expr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3064,10 +3064,20 @@ exprt verilog_typecheck_exprt::convert_binary_expr(binary_exprt expr)

return std::move(expr);
}
else if(expr.id() == ID_sva_sequence_concatenation) // a ##b c
{
expr.type() = bool_typet();
convert_expr(expr.op0());
make_boolean(expr.op0());
convert_expr(expr.op1());
make_boolean(expr.op1());
return std::move(expr);
}
else if(
expr.id() == ID_sva_sequence_intersect ||
expr.id() == ID_sva_sequence_throughout ||
expr.id() == ID_sva_sequence_within)
expr.id() == ID_sva_sequence_within ||
expr.id() == ID_sva_sequence_first_match)
{
auto &binary_expr = to_binary_expr(expr);

Expand Down Expand Up @@ -3197,44 +3207,79 @@ exprt verilog_typecheck_exprt::convert_binary_expr(binary_exprt expr)
expr.type() = bool_typet{};
return std::move(expr);
}
else
else if(
expr.id() == ID_plus || expr.id() == ID_minus || expr.id() == ID_mult ||
expr.id() == ID_power)
{
// type is guessed for now
// hopefully propagate_type will fix it

Forall_operands(it, expr)
convert_expr(*it);
for(auto &op : expr.operands())
convert_expr(op);

tc_binary_expr(expr);

if(expr.id()==ID_plus ||
expr.id()==ID_minus ||
expr.id()==ID_mult ||
expr.id()==ID_power)
no_bool_ops(expr);
no_bool_ops(expr);

expr.type()=expr.op0().type();
expr.type() = expr.op0().type();
return std::move(expr);
}
else if(
expr.id() == ID_bitand || expr.id() == ID_bitor || expr.id() == ID_bitxor ||
expr.id() == ID_bitxnor || expr.id() == ID_bitnand ||
expr.id() == ID_bitnor)
{
for(auto &op : expr.operands())
convert_expr(op);

// check Boolean operators
tc_binary_expr(expr);

if(expr.type().id()==ID_bool)
expr.type() = expr.op0().type();

// Boolean?
if(expr.type().id() == ID_bool)
{
if(expr.id()==ID_bitand)
if(expr.id() == ID_bitand)
expr.id(ID_and);
else if(expr.id()==ID_bitor)
else if(expr.id() == ID_bitor)
expr.id(ID_or);
else if(expr.id()==ID_bitxor)
else if(expr.id() == ID_bitxor)
expr.id(ID_xor);
else if(expr.id()==ID_bitxnor)
else if(expr.id() == ID_bitxnor)
expr.id(ID_equal);
else if(expr.id()==ID_bitnand)
else if(expr.id() == ID_bitnand)
expr.id(ID_nand);
else if(expr.id()==ID_bitnor)
else if(expr.id() == ID_bitnor)
expr.id(ID_nor);
}

return std::move(expr);
}
else if(
expr.id() == ID_and || expr.id() == ID_or || expr.id() == ID_xor ||
expr.id() == ID_xnor || expr.id() == ID_nand || expr.id() == ID_nor)
{
for(auto &op : expr.operands())
{
convert_expr(op);
make_boolean(op);
}

tc_binary_expr(expr);

expr.type() = expr.op0().type();

return std::move(expr);
}
else if(expr.id() == ID_verilog_value_range)
{
for(auto &op : expr.operands())
convert_expr(op);
expr.type() = expr.op0().type();
return std::move(expr);
}
else
{
throw errort().with_location(expr.source_location())
<< "no conversion for binary expression " << expr.id();
}
}

/*******************************************************************\
Expand Down Expand Up @@ -3352,7 +3397,7 @@ exprt verilog_typecheck_exprt::convert_trinary_expr(ternary_exprt expr)
expr.type()=expr.op1().type();
return std::move(expr);
}
else if(expr.id()==ID_sva_cycle_delay) // #[1:2] something
else if(expr.id() == ID_sva_cycle_delay) // ##[1:2] something
{
expr.type()=bool_typet();
convert_expr(expr.op0());
Expand Down