refactor: remove execution_time from tool reporting #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 25, 2025
lion1991
pushed a commit
to lion1991/codemcp
that referenced
this pull request
Mar 25, 2025
Some tools report execution time (execution_time). This is pointless, remove it from all of them. ```git-revs 74289f5 (Base revision) 9c5623b Remove execution_time calculation and durationMs from glob_files output 3ea1c75 Remove start_time and execution stats related code from chmod function docstring and start 3ceef27 Remove durationMs from chmod early return statements e5602f6 Remove execution_time calculation and durationMs from chmod output 53df773 Remove durationMs from chmod error handling 30314a0 Remove execution stats mention and start_time from git_log function aad0e1e Remove execution_time calculation and durationMs from git_log output 0155b92 Remove durationMs from git_log error handling 5accde2 Remove execution stats mention and start_time from git_blame function c7686d3 Remove execution_time calculation and durationMs from git_blame output a47db12 Remove durationMs from git_blame error handling ea94b86 Remove execution stats mention and start_time from git_diff function 71c0dca Remove execution_time calculation and durationMs from git_diff output 7ea1010 Remove durationMs from git_diff error handling f6e301c Remove execution stats mention and start_time from git_show function b4553d7 Remove execution_time calculation and durationMs from git_show output 550f606 Remove durationMs from git_show error handling dafec72 Remove execution stats mention and start_time from grep_files function 8d2a6d0 Remove execution_time calculation and durationMs from grep_files output HEAD Auto-commit lint changes ``` codemcp-id: 211-refactor-remove-execution-time-from-tool-reporting ghstack-source-id: cae15f1 Pull-Request-resolved: ezyang#205
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Some tools report execution time (execution_time). This is pointless, remove it from all of them.
codemcp-id: 211-refactor-remove-execution-time-from-tool-reporting