fix: correct non-compliant exception handling #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 25, 2025
lion1991
pushed a commit
to lion1991/codemcp
that referenced
this pull request
Mar 25, 2025
There are some try...except blocks in the codebase which are not in compliance with policy (do not suppress exceptions, raise to top level). codemcp/tools/git_blame.py has an example. Find and fix these. ```git-revs 606e12c (Base revision) 62b9f5d Remove try-except block and set check=True to allow exceptions to propagate to top level c556b14 Remove try-except block and set check=True to allow exceptions to propagate to top level 8d7c8dd Remove try-except block and set check=True to allow exceptions to propagate to top level 9721f29 Remove try-except block and set check=True to allow exceptions to propagate to top level bda80ff Remove try-except block to allow exceptions to propagate to top level 0a926f0 Remove inner try-except block to allow exceptions to propagate to top level HEAD Remove try-except block that suppresses exceptions and raise an error when commit fails ``` codemcp-id: 212-fix-correct-non-compliant-exception-handling ghstack-source-id: a8a894f Pull-Request-resolved: ezyang#207
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
There are some try...except blocks in the codebase which are not in compliance with policy (do not suppress exceptions, raise to top level). codemcp/tools/git_blame.py has an example. Find and fix these.
codemcp-id: 212-fix-correct-non-compliant-exception-handling