fix: typecheck line_endings.py and create editorconfig stub #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 25, 2025
ezyang
added a commit
that referenced
this pull request
Mar 25, 2025
Typecheck codemcp/line_endings.py and fix errors. Typecheck ONLY this file (typecheck command takes a filename as argument). As part of this you will need to generate a stub file for editorconfig. Do this by hand, you ONLY have tools accessible to you as described in prompt. ```git-revs 55c4bef (Base revision) 142894b Create editorconfig stub file c9476b2 Add stub path to pyright configuration 24026ab Fix handling of None case in check_editorconfig function 40adebd Update editorconfig stub to reflect that get_properties doesn't return None d9f3a40 Add Any type import 96cc642 Remove unnecessary None check as options can't be None 5c3daa5 Create stub file for glob module 08fbef8 Remove unused Any import 36eccca Create __init__.pyi for codemcp stubs package 33f1cc8 Add more type imports 709f58a Add proper type annotations for keyword arguments in functions 0ddf6a9 Update find function to pass correct keyword args and improve documentation da24fe2 Auto-commit format changes HEAD Auto-commit lint changes ``` codemcp-id: 216-fix-typecheck-line-endings-py-and-create-editorcon ghstack-source-id: 7ec8fba Pull-Request-resolved: #209
ezyang
added a commit
that referenced
this pull request
Mar 25, 2025
Typecheck codemcp/line_endings.py and fix errors. Typecheck ONLY this file (typecheck command takes a filename as argument). As part of this you will need to generate a stub file for editorconfig. Do this by hand, you ONLY have tools accessible to you as described in prompt. ```git-revs 55c4bef (Base revision) 142894b Create editorconfig stub file c9476b2 Add stub path to pyright configuration 24026ab Fix handling of None case in check_editorconfig function 40adebd Update editorconfig stub to reflect that get_properties doesn't return None d9f3a40 Add Any type import 96cc642 Remove unnecessary None check as options can't be None 5c3daa5 Create stub file for glob module 08fbef8 Remove unused Any import 36eccca Create __init__.pyi for codemcp stubs package 33f1cc8 Add more type imports 709f58a Add proper type annotations for keyword arguments in functions 0ddf6a9 Update find function to pass correct keyword args and improve documentation da24fe2 Auto-commit format changes 8dd6dbc Auto-commit lint changes eeb247b Remove unnecessary Any import 2f5e0e5 Simplify the translate_pattern function to use a single editorconfig parameter 412d84f Simplify the make_matcher function to use a single editorconfig parameter 408bb2c Simplify the match function to use a single editorconfig parameter 5d8582a Simplify the filter function to use a single editorconfig parameter 6f8d147 Simplify the find function to use a single editorconfig parameter db47561 Update glob_match call to use the new editorconfig parameter 9ea21df Update test_editorconfig_braces to use the new editorconfig parameter e1b34de Update test_editorconfig_asterisk and test_editorconfig_double_asterisk to use the new editorconfig parameter b3151b9 Update test_combined_features to use the new editorconfig parameter bc7166c Update test_complex_patterns to use the new editorconfig parameter 76f177f Update test_edge_cases to use the new editorconfig parameter 823384c Fix recursive translate_pattern call to use the new editorconfig parameter HEAD Auto-commit format changes ``` codemcp-id: 216-fix-typecheck-line-endings-py-and-create-editorcon ghstack-source-id: 03c7f4b Pull-Request-resolved: #209
This was referenced Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Typecheck codemcp/line_endings.py and fix errors. Typecheck ONLY this file (typecheck command takes a filename as argument). As part of this you will need to generate a stub file for editorconfig. Do this by hand, you ONLY have tools accessible to you as described in prompt.
codemcp-id: 216-fix-typecheck-line-endings-py-and-create-editorcon