Skip to content

fix: typecheck and fix errors #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

ezyang
Copy link
Owner

@ezyang ezyang commented Mar 25, 2025

Stack from ghstack (oldest at bottom):

Run typecheck and fix errors. There are many errors so make a plan about which module to do first based on dependencies.

cbc5d78  (Base revision)
3e0e7f2  Fix return type of run_command to specify CompletedProcess type parameters
7c760d1  Add type parameter to CompletedProcess instantiation
d66377f  Fix type issue with wait_time in TimeoutExpired constructor by ensuring it's a float
688b278  Remove unnecessary isinstance check since input is already typed as Optional[str]
5069fc5  Add necessary imports and type definitions for anyio file operations
60cc81f  Fix the mode type parameter in async_open_text function
e658af6  Fix the mode type parameter in async_open_binary function
96e35cc  Fix the mode type parameter in async_write_text function
263feed  Fix the mode type parameter in async_write_binary function and remove the unnecessary newline parameter for binary mode
5208044  Update the async_readlines function to use OpenTextMode
9520770  Expand OpenTextMode and OpenBinaryMode literals to include write and append modes
dc10140  Add proper imports including type definitions
24b253e  Update async_open_text to use OpenTextMode
c495c2d  Update write_text_content to use Optional instead of union type
5eb7591  Fix the write mode by using an explicit OpenTextMode variable
7d8a50d  Update return type annotation in check_file_path_and_permissions
f02bdae  Fix returncode handling to avoid None value
121b4d9  Remove unused Any import
bea7686  Remove unused imports
07dd0c8  Fix async_readlines by using string literal for mode
f020f12  Remove unused imports from file_utils.py
6202623  Cast stdout to str in get_head_commit_message function
350e6ed  Cast stdout to str in get_head_commit_hash function
6683f1b  Cast stdout to str in get_repository_root function
ed6d8c0  Cast stdout to str in get_ref_commit_chat_id function
e214ad5  Cast tree_hash to str in create_commit_reference
672df85  Cast head_hash to str
1664682  Cast commit_hash to str
5d39ae8  Cast tree_hash and ref_message to str
5eb976c  Cast new_commit_hash to str
5e4e2bc  Fix chat_id parameter using Optional type
75fc0b2  Add Union to imports in code_command.py
9eb3519  Add necessary imports to common.py
572f0c3  Update truncate_output_content to handle bytes input
1f7c76a  Add type annotation for the result list in get_edit_snippet
ab4cd32  Add type annotation for processed_lines list in truncate_output_content
24e0ea9  Convert chat_id to string to fix type error in commit_changes call
c5a765a  Convert chat_id to string for earlier commit_changes call
HEAD     Auto-commit format changes

codemcp-id: 220-fix-typecheck-and-fix-errors

[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant