fix: resolve type checking errors in code_command.py #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 25, 2025
ezyang
added a commit
that referenced
this pull request
Mar 25, 2025
Let's continue fixing the typecheck errors in the codemcp project. We've already made progress on shell.py, async_file_utils.py, file_utils.py, and git_query.py. Now we should focus on fixing the remaining issues in code_command.py, git_message.py, and hot_reload_entry.py. Let's start with code_command.py which has issues with return type annotations and handling of string/bytes types. ```git-revs 5af23b5 (Base revision) 1d3d1a5 Remove unused Union import 3439a2e Add type ignore comments to handle unknown types in return statements dee99a9 Add type arguments for dict in append_metadata_to_message 8f2e147 Add more type imports needed for annotations ed75b38 Add type arguments for Task and Queue 197bfef Add type arguments for Queue in _run_manager_task 9f98a5f Add type annotation for kwargs parameter in call_tool 414dbeb Add type annotation for kwargs parameter in codemcp function 49f74b5 Add a default case to the match statement for exhaustive handling 4c483d6 Remove unused imports and add Future import ecc9c67 Add type annotation for stop_future c051d46 Add type annotation for response_future and handle None check for _request_queue HEAD Auto-commit format changes ``` codemcp-id: 221-fix-resolve-type-checking-errors-in-code-command-p ghstack-source-id: 4f73277 Pull-Request-resolved: #212
This was referenced Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Let's continue fixing the typecheck errors in the codemcp project. We've already made progress on shell.py, async_file_utils.py, file_utils.py, and git_query.py. Now we should focus on fixing the remaining issues in code_command.py, git_message.py, and hot_reload_entry.py. Let's start with code_command.py which has issues with return type annotations and handling of string/bytes types.
codemcp-id: 221-fix-resolve-type-checking-errors-in-code-command-p