Allow .tpl of database secret names and image repository and tag
#6711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhotan
force-pushed
the
mhotan/templatable-db-name
branch
from
0cc7cee to
711e80a
Compare
template value This adds support for the ability to set `.Values.flyte.common.databaseSecret.name` to a Helm template value. e.g. `.Values.global.MY_SECRET_NAME` Signed-off-by: Mike Hotan <[email protected]>
mhotan
force-pushed
the
mhotan/templatable-db-name
branch
from
711e80a to
4cdf120
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6711 +/- ##
==========================================
+ Coverage 58.57% 59.72% +1.14%
==========================================
Files 929 929
Lines 70879 57995 -12884
==========================================
- Hits 41520 34636 -6884
+ Misses 26206 20206 -6000
Partials 3153 3153
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mhotan
force-pushed
the
mhotan/templatable-db-name
branch
from
4e76b6c to
b8f3252
Compare
Signed-off-by: Michael Hotan <[email protected]>
mhotan
force-pushed
the
mhotan/templatable-db-name
branch
from
b8f3252 to
7e1e03b
Compare
mhotan
changed the title
.Values.flyte.common.databaseSecret.name to reference Helm template value.tpl of database secret names and image repository and tag
Signed-off-by: Michael Hotan <[email protected]>
mhotan
force-pushed
the
mhotan/templatable-db-name
branch
from
8b1ec15 to
16fb9a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Union uses flyte-core as a subchart. This pattern is likely applicable for other organizations as well.
This PR makes it so
.Values.flyte.common.databaseSecret.name,*.image.repository,*.image.tagrespects Helm template values through thetplfunction.Additionally, we are updating Helm version to 3.19 as it is more up to date with latest release.
Summary by Bito