rust: Wrap Context in Arc<> #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasmith
changed the title
gasmith
force-pushed
the
gasmith/fg-10745-ns-arc
branch
from
dd24a84 to
3ee1893
Compare
gasmith
changed the title
gasmith
force-pushed
the
gasmith/fg-10745-ns-arc
branch
2 times, most recently
from
a10dd95 to
763aeba
Compare
gasmith
force-pushed
the
gasmith/fg-10745-ns-arc
branch
from
763aeba to
1f40c6b
Compare
This was referenced Mar 14, 2025
jtbandes
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We're going to need to store references to the
Contexton both channels (for access to subscriptions) and sinks (for dynamic subscription management and unregister-on-drop), so we're going to want anArc. Since the context holdsArcreferences to channels and sinks, channels and sinks will holdWeakreferences back to the context.