Skip to content

fix: Add missing dependencies in package.xml #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: humble
Choose a base branch
from

Conversation

wentasah
Copy link

Without these, package build fails at configure stage.

Without these, package build fails at configure stage.
@Smith-JackSmith
Copy link

Can you please provide details about your environment.

We are able to build, without error, starting with a "vanilla" Ubuntu 22.04 machine, following our instructions here for the Local Machine build, as well as the container builds.

@wentasah
Copy link
Author

We're building ROS packages with the Nix package manager in this project. Nix builds each package in a sandbox with just the declared dependencies available and nothing more. If you require some library in CMakeLists.txt, but this library is missing in package.xml, the build fails. I guess that in your builds, you build multiple of your packages together and if one package depends on say eigen, then rosdep installs this package and it will be available for all other package packages even without them declaring it as a dependency. I think that if you try to build your packages one by one in clean Ubuntu, you would encounter the errors too.

You can see the log from the failed build, which this PR should fix here.

@Smith-JackSmith
Copy link

Indeed, we always build franka_ros2 as a whole , not the individual packages.

I will investigate. Thank you for reporting this, and the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants