Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset cleanup #62

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Asset cleanup #62

wants to merge 12 commits into from

Conversation

jamesdunham
Copy link
Member

Remove unused assets for:

  • MAG-field to CSET-field project ("v2")
  • Deprecated ZH-specific functionality

We used these files when initially creating the new L2s/L3s, but they're
now out of date. We've made subsequent changes directly to
all_fields.tsv, which is now at the top of our workflow for updating
field text. So for clarity I'm removing these assets, because they contain
information that's *almost* the same as in field_meta.

I'm putting the notebook I used to create an updated version of
field_meta.jsonl that incorporates our final decisions from
l2_revisions.xlsx in an analysis subdirectory.
This commit deletes some code and files that we originally used to
derive our L0-L1 taxonomy from the MAG taxonomy, and find corresponding
Wiki text given a large set of field names; we aren't using this now.
@jamesdunham jamesdunham requested a review from rggelles January 28, 2025 16:56
Copy link
Member

@rggelles rggelles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long-term if this is still in use I think it would be nice to convert this to a real Python file (notebooks can have weird dependency issues that are harder to work out and are more of a pain to re-run) but not a big deal for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants