-
Notifications
You must be signed in to change notification settings - Fork 389
fix the bug of xarm_robotiq_140 asset load and conrol problem #1224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thank you, I presume this is to fix #1165? As for the PR we currently don't want to have too many of the same type of robot in the package assets folder (it increases the package size unnecessarily). For extra robots we usually move them to a separate repo to be downloaded through the releases tab (eg Unitree g1, UR10e and a few others). The test files should also not be in this repo. I recommend moving them to the repo dedicated to hosting the asset files for the robot. To move forward could you make a repo similar to this one? Detail the changes made to the original URDF(s) and include the original license. https://github.com/haosulab/ManiSkill-WidowX250S |
|
One last point if possible to test the grasping we usually make sure the robot can solve the pick cube task. You can look at the code to see how we set up other robots. |
|
yes, it is a fix for #1165. I will follow the https://github.com/haosulab/ManiSkill-WidowX250S project and add the grasping task example for this project |
|
Hi, Additionally, I have ensured that the robot is functional in the pick-cube task, as demonstrated in the code at this link. I’d be happy to offer any further assistance to improve the code~ |
|
Thanks again for your great work! |
As mentioned in #1165 (comment), the drive poses of different gripper is different, i think your urdf mentioned in #1165 (comment) is not the robotiq-140 gripper, so the drive pose of this codebase is not suitable for you. |
|
Thanks for your kind reply. |

Here we fix the asset load and control bug for xarm robotiq 140 robot.
We provide mani_skill/examples/compute_the_drive_for_robotiq_140.py to compute the drive parameter.
We provide mani_skill/examples/test_robotiq_140.py to validate the robot control.
We provide the mani_skill/agents/robots/xarm6/xarm6_robotiq_140.py and mani_skill/assets/robots/xarm6_robotiq_140 for xarm6_robotiq_140