Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product usage reporting docs #28858

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Product usage reporting docs #28858

merged 4 commits into from
Nov 12, 2024

Conversation

VioletHynes
Copy link
Contributor

@VioletHynes VioletHynes commented Nov 7, 2024

Description

These are the docs for product usage reporting, and the changelog for the feature.

There was no 1.19 release notes page available at the time of writing, but it would need to be added later. Further, if we wanted to backport this to a minor release, we'd need to add a release note page for that, too, as we do not usually backport major changes like this.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Nov 7, 2024
@@ -456,6 +465,11 @@
},
{
"title": "<code>sentinel</code>",
"badge": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to my PR but this should be there since it's an enterprise feature.

Copy link

github-actions bot commented Nov 7, 2024

CI Results:
All Go tests succeeded! ✅

@VioletHynes VioletHynes added this to the 1.19.0-rc milestone Nov 7, 2024
@VioletHynes VioletHynes marked this pull request as ready for review November 7, 2024 21:08
@VioletHynes VioletHynes requested a review from a team as a code owner November 7, 2024 21:08
Copy link

github-actions bot commented Nov 7, 2024

Build Results:
All builds succeeded! ✅

@mpalmi mpalmi added the docs label Nov 11, 2024
@VioletHynes VioletHynes merged commit aa09d0c into main Nov 12, 2024
38 checks passed
@VioletHynes VioletHynes deleted the violethynes/VAULT-32201 branch November 12, 2024 14:15
VioletHynes added a commit that referenced this pull request Nov 14, 2024
* First draft of product usage reporting docs

* Table data, fix issues

* Changelog
VioletHynes added a commit that referenced this pull request Nov 14, 2024
* First draft of product usage reporting docs

* Table data, fix issues

* Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.18.x docs hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants