Skip to content

Clean-up of main repo 4 #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

johanneskbl
Copy link
Contributor

@johanneskbl johanneskbl commented Apr 3, 2025

What is this

Clean-up and documentation of aerial_robot_base.

Details

  • commit1: Renaming of 1/main_rate = main_loop_dt
  • commit2: Fix declaration and move to header file

TODO

  • In my opinion, variables that indicate time should be named with "t". There are multiple other variables in the rest of the code base to use "u", e.g. "loop_du", instead. Since "u" is generally reserved for the control input I would propose to change all those variables to make it easier to understand the code more intuitive. I'm open to be convinced otherwise :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant