-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[euscollada] Test predefined pose methods in generated pr2 model #175
Open
wkentaro
wants to merge
6
commits into
jsk-ros-pkg:master
Choose a base branch
from
wkentaro:pr2-test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkentaro
force-pushed
the
pr2-test
branch
3 times, most recently
from
April 18, 2016 03:56
2959a25
to
153f242
Compare
wkentaro
changed the title
[WIP] [euscollada] Test predefined pose methods in generated pr2 model
[euscollada] Test predefined pose methods in generated pr2 model
Apr 18, 2016
wkentaro
force-pushed
the
pr2-test
branch
3 times, most recently
from
April 27, 2016 08:23
c0bcc3d
to
4b2ffc2
Compare
|
having test case is nice, but depending on jsk_tools means you have to take care of this package because this package seems less maintained and could not find active user/maintainers. |
So do I need to remove the dependency on jsk_tools? |
Modified: - euscollada/CMakeLists.txt - euscollada/package.xml Added: - euscollada/.gitignore
wkentaro
force-pushed
the
pr2-test
branch
2 times, most recently
from
August 30, 2016 10:33
1c29d0b
to
11d2da3
Compare
Modified: - euscollada/CMakeLists.txt Added: - euscollada/test/test_pr2.sh
I removed the dependency on jsk_tools, so it uses only rostest, euslisp, roseus at testing. |
need to resolve conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on jsk-ros-pkg/jsk_common#1371
Modified:
Added: