Skip to content

Memory-mapped caching for image translation training #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 86 commits into from
Mar 27, 2025
Merged

Conversation

ziw-liu
Copy link
Collaborator

@ziw-liu ziw-liu commented Jan 6, 2025

#195 implemented in-RAM caching for image translation trainings. However it does not scale to datasets larger than available system memory. This PR implements a node-local disk cache via tensordict's memory-mapped tensor.

@edyoshikun
Copy link
Contributor

Marking this ready for review. Taking a look now! @ziw-liu

@edyoshikun edyoshikun marked this pull request as ready for review March 25, 2025 00:46
Base automatically changed from segmentation-module to main March 25, 2025 04:16
@ziw-liu ziw-liu added this to the v0.3.0 milestone Mar 25, 2025
@ziw-liu ziw-liu requested a review from edyoshikun March 26, 2025 17:21
Copy link
Contributor

@edyoshikun edyoshikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ziw-liu ziw-liu merged commit 89b2917 into main Mar 27, 2025
4 checks passed
@ziw-liu ziw-liu deleted the mmap-cached branch March 27, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request translation Image translation (VS)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants