-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src/itx.rs
: Deduplicate w/ generics
#683
Conversation
src/itx.rs
: Deduplicate w/genericssrc/itx.rs
: Deduplicate w/ generics
6ab7b27
to
5d2ea22
Compare
5bbdc09
to
150dacb
Compare
4da4ab3
to
a52dcd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't thoroughly reviewed the macros and initialization logic (comparing them to C), as you said you looked at that pretty thoroughly already. I can if you think you could've missed something, though. Besides that, I had a few other small comments. Also, the debug info improvements are very nice.
a52dcd4
to
bbaca69
Compare
bbaca69
to
8bfcc09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The translation of the C macros looks correct to me. Is there a reason you didn't setup macros for assigning the C fallback functions though? I'm assuming it's correct because what we should have should be the direct result of expanding the macros in C and should have been the same between the 8bpc and 16bpc files, so if you copied it out from one of them then it should be correct here. But it's hard to verify without having the macros setup the same way.
We can later change the fallbacks to return |
74a007d
to
d6ebd3d
Compare
Derp, I forgot to push that change; sorry about that . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated macros for initializing the fallback fns look good too 👍 Thanks for adding those.
First commit emits debug info for assembly on debug builds. This aids testing and debugging. Closes #25.
NOTE to self: need to update the macro docs in
bitdepths.rs
if the overall approach looks good.