Skip to content

Consolidate Standalone and Cluster Snapshot Metadata #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jun 12, 2025

Conversation

vazois
Copy link
Collaborator

@vazois vazois commented Mar 31, 2025

This PR consolidates the standalone and cluster snapshot metadata format by making the user cookie part of HybridLogRecoveryInfo. To achieve the following features were added

  • Cookie is integrated into the HybridLogRecoveryInfo
  • An interface was exposed to enable injecting a function that is used to build a custom cookie
  • The HistoryId parameters were moved inside the DeviceLogManager to be used across standalone and cluster.
  • Added unit test to validate conversion from cluster to standalonde and vice-versa.

NOTE: Added backwards compatibility code to ensure that old format is supported. This code should be deprecated as soon as we release the next version of Garnet.

@vazois vazois force-pushed the vazois/checkpoint-upgrade branch 7 times, most recently from 1b4acb2 to 89c161d Compare April 2, 2025 20:23
@vazois vazois force-pushed the vazois/checkpoint-upgrade branch 2 times, most recently from 9d76661 to 3ee8c69 Compare April 7, 2025 21:15
@vazois vazois force-pushed the vazois/checkpoint-upgrade branch 3 times, most recently from d58930d to ebd1eaa Compare June 4, 2025 18:16
@vazois vazois marked this pull request as ready for review June 4, 2025 18:28
@vazois vazois force-pushed the vazois/checkpoint-upgrade branch from ebd1eaa to fe6cb1d Compare June 4, 2025 18:29
@TalZaccai TalZaccai requested a review from badrishc June 10, 2025 18:16
@vazois vazois merged commit 2de1c3a into microsoft:main Jun 12, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants