-
Notifications
You must be signed in to change notification settings - Fork 75
Adjust position of drawers and stickcategoryheader with active smartmenu top bar, resolves #870 #879 #899 #871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
085b8c3
to
017b9aa
Compare
0d9db18
to
89a3b4f
Compare
89a3b4f
to
e29337b
Compare
Hi @christianwolters , many thanks for this contribution. I just rebased the PR onto latest master and made some minor review changes in a separate commit. Regarding #870, I can confirm that the bug is solved by this patch. Regarding #879, I think there is some room for improvement. ![]() Additionally, I would like to point out that we have already some places where the Would you mind to interweave your new handling for the course index with the existing handling for the message drawer and use the same breakpoints? And it would be a great benefit if you could also modify the handling of the message drawer to use the new Many thanks, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
Hey @abias, thanks for pointing this out. I''ve fixed this for small and middle-size screens (not pushed yet). During testing, I encountered additonal bugs, when top menubar and footerbar are both enabled:
|
7bc0c9b
to
8a73827
Compare
see #870 , #879 and #899.