Skip to content

Adjust position of drawers and stickcategoryheader with active smartmenu top bar, resolves #870 #879 #899 #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

christianwolters
Copy link
Member

@christianwolters christianwolters commented Mar 20, 2025

see #870 , #879 and #899.

@christianwolters christianwolters changed the title Fix: top poistion of sticky category heading with active smartmenu menu bar, resolves #870 Fix: top position of sticky category heading with active smartmenu menu bar, resolves #870 Mar 20, 2025
@christianwolters christianwolters changed the title Fix: top position of sticky category heading with active smartmenu menu bar, resolves #870 Fix top position of sticky category heading with active smartmenu menu bar, resolves #870 Mar 20, 2025
@christianwolters christianwolters changed the title Fix top position of sticky category heading with active smartmenu menu bar, resolves #870 Adjust position of drawers and stickcategoryheader with active smartmenu top bar, resolves #870 #879 Mar 27, 2025
@christianwolters christianwolters marked this pull request as ready for review March 29, 2025 14:56
@christianwolters christianwolters requested a review from abias April 1, 2025 07:34
@abias abias self-assigned this Apr 2, 2025
@abias
Copy link
Member

abias commented Apr 2, 2025

Hi @christianwolters ,

many thanks for this contribution.

I just rebased the PR onto latest master and made some minor review changes in a separate commit.

Regarding #870, I can confirm that the bug is solved by this patch.

Regarding #879, I think there is some room for improvement.
On the one hand, you have to note that on small screens, the menu bar is placed behind the course index drawer and not above it anymore. But this means that the calculated height of the drawer does not fit anymore on small screens:

grafik

Additionally, I would like to point out that we have already some places where the .boost-union-menubar class is used as a selector, especially for handling the height of the message drawer together with the menu bar.

Would you mind to interweave your new handling for the course index with the existing handling for the message drawer and use the same breakpoints? And it would be a great benefit if you could also modify the handling of the message drawer to use the new $boost-union-smartmenu-menubar-height variable as well.

Many thanks,
Alex

Copy link
Member

@abias abias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@christianwolters
Copy link
Member Author

christianwolters commented Apr 13, 2025

Hey @abias,

thanks for pointing this out.

I''ve fixed this for small and middle-size screens (not pushed yet).

During testing, I encountered additonal bugs, when top menubar and footerbar are both enabled:

  • I'll create a seperate issue for this
  • but will adress this in this PR as well

@christianwolters christianwolters changed the title Adjust position of drawers and stickcategoryheader with active smartmenu top bar, resolves #870 #879 Adjust position of drawers and stickcategoryheader with active smartmenu top bar, resolves #870 #879 #899 Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants