refactor!: Port to irpc, remove quic-rpc and cli impl #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simulation reportLast updated: 2025-06-02T11:55:54Z |
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-gossip/pr/67/docs/iroh_gossip/ Last updated: 2025-06-02T11:50:55Z |
Frando
force-pushed
the
Frando/irpc
branch
3 times, most recently
from
e3d6a72 to
4a7decc
Compare
Frando
force-pushed
the
proto-fixes
branch
2 times, most recently
from
413f3a8 to
6f2656f
Compare
Frando
force-pushed
the
Frando/test-net-big
branch
from
cfefa65 to
a80bf1b
Compare
Frando
force-pushed
the
Frando/test-net-big
branch
from
a80bf1b to
51218d1
Compare
Frando
commented
May 20, 2025
| /// ALPN protocol name | ||
| pub const GOSSIP_ALPN: &[u8] = b"/iroh-gossip/0"; | ||
| /// Default channel capacity for topic subscription channels (one per topic) | ||
| const TOPIC_EVENTS_DEFAULT_CAP: usize = 2048; |
There was a problem hiding this comment.
Moved to crate::net::handles
Frando
changed the title
Frando
commented
May 29, 2025
divagant-martian
approved these changes
Jun 4, 2025
|
While working on the breaking changes list, these two points popped up that might need some consideration:
|
4 tasks
Frando
changed the title
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
quic-rpcbased RPC implementationirpcfor communication with theGossipactor, enabling an identical API between local and RPC useGossipApi. AGossipinstance always derefs toGossipApi, butGossipApican also be created by connecting over RPC. Via this construction, the local and remote APIs are guaranteed to be identical.Gossiponly has these additional functions, which don't make sense over RPC:handle_connection,shutdown,metrics, andlisten(to expose via RPC).Breaking Changes
GossipReceiverdoes no longer implementSync. This should not be an issue, because all methods need&mut selfanyways. If this does bother you, please open an issue so that we can discuss.GossipSenderis no longerClone, andGossipSender::sendneeds&mut self. This is a result of moving toirpc, see this issueclimodule has been removed without alternatives, feel free to copy-paste code into your own crate.rpcmodule has been removed. UseGossip::listenandGossipApi::connectto use iroh-gossip over a RPC connection.net::Errorvariants changed:RpcSendandRpcRecvwere removedGossip::subscribe_with_streamhas been removed. If you needed this, you'd need to build this with a task loop instead.Gossip::subscribe,Gossip::subscribe_with_optsandGossip::subscribe_and_joinare now methods onGossipApi.Gossipderefs toGossipApiso this should need no changes.GossipApi::subscribe(previouslyGossip::subscribe) is now asyncNotes & open questions
Change checklist