277 load cell validity check #379
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkevinbest
force-pushed
the
277-load-cell-validity-check
branch
from
827d710 to
597844b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added logic to the SRI/Dephy amplifier class to detect broken wires. This was the problem that was very hard to diagnose at biorob, since just one of the loadcell wires was broken.
The new code monitors the raw ADC values and throws an error if it is consistently measures saturation at max or min values. Unit tests added as well. The user can disable this if they want during the amplifier constructor, but the default is enabled.
I also fixed some typing issues in the loadcell class regarding the size of the raw uints, and added a new "counter" class to the math module.