Consider XXXX-XX-XX as missing date #1913
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numbering removed to make edits easier.
Previously, this was considered an ambiguous date with a range of '[0001-01-01, present]'. That may be somewhat correct, but it has the side effect of passing min/max date filters. Other missing dates such as empty string are dropped by those date filters, and it seems more reasonable to consider XXXX-XX-XX the same way.
victorlin
commented
Oct 22, 2025
| # 1. Check if value is an exact date in the specified format (fmt). | ||
| # Check if value is a missing date. | ||
| if RE_AUGUR_MISSING_DATE.match(value): | ||
| return None |
Member
Author
There was a problem hiding this comment.
Error from wnv check:
TypeError: unsupported operand type(s) for /: 'NoneType' and 'int'
This is coming from augur frequencies. I'll run locally to investigate.
5 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1913 +/- ##
==========================================
+ Coverage 74.13% 74.14% +0.01%
==========================================
Files 82 82
Lines 8977 8981 +4
Branches 1825 1826 +1
==========================================
+ Hits 6655 6659 +4
Misses 2018 2018
Partials 304 304 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Previously, this was considered an ambiguous date with a range of '[0001-01-01, present]'. That may be somewhat correct, but it has the side effect of passing min/max date filters. Other missing dates such as empty string are dropped by those date filters, and it seems more reasonable to consider XXXX-XX-XX the same way.
Related issue(s)
Closes #1894
Checklist