Skip to content

Conversation

@perher
Copy link
Contributor

@perher perher commented Aug 29, 2025

This is a large collection of fixes that mostly improves on the subschemas (allOf/anyOf) support added in #99.

Keeping this as one large MR for now to reflect the larger work being done in my fork as this project seems less active nowadays.

New features:

Fixes:

Breaking changes:

  • anyOf could mark properties as required even if they were only required in one of the subschemas

Includes PRs

@codecov
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

❌ Patch coverage is 22.33918% with 664 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@4b5de3c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
tests/data/core/anyOf/anyOfMultipleRequired.go 0.00% 124 Missing ⚠️
tests/data/core/allOf/allOfMultipleRequired.go 0.00% 118 Missing ⚠️
tests/data/core/anyOf/anyOfWithDirectProperties.go 0.00% 86 Missing ⚠️
tests/data/core/allOf/allOfWithAnyOf.go 0.00% 80 Missing ⚠️
tests/data/core/anyOf/anyOf.ref.go 0.00% 80 Missing ⚠️
tests/data/core/allOf/allOfWithDirectProperties.go 0.00% 76 Missing ⚠️
tests/data/core/allOf/allOfNestedRefs.go 0.00% 60 Missing ⚠️
pkg/generator/schema_generator.go 77.77% 14 Missing and 8 partials ⚠️
pkg/schemas/model.go 79.16% 10 Missing and 5 partials ⚠️
pkg/schemas/types.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #473   +/-   ##
=======================================
  Coverage        ?   39.83%           
=======================================
  Files           ?       68           
  Lines           ?     7420           
  Branches        ?        0           
=======================================
  Hits            ?     2956           
  Misses          ?     4183           
  Partials        ?      281           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@perher
Copy link
Contributor Author

perher commented Aug 29, 2025

Above are tagged as v0.21.0-beta.0 in https://github.com/perher/go-jsonschema

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant