Skip to content

Errata: fix a couple of spots in server upcall functions #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rhc54
Copy link
Member

@rhc54 rhc54 commented Jun 13, 2025

Server upcall functions were required to return prior to executing the callback function. This was a limitation of the implementation and not a requirement of the Standard - the statements should never have been included here.

FWIW: the limitation has subsequently been removed from the reference implementation.

In the pmix_server_iof_fn_t, clarify that an error status can be returned either directly by the function or in the callback function. It does not require that the host execute the callback to return an error, as was implied by the current language.

@rhc54 rhc54 added this to the PMIx v6.0 Standard milestone Jun 13, 2025
@rhc54 rhc54 self-assigned this Jun 13, 2025
@rhc54 rhc54 added the Errata label Jun 13, 2025
@rhc54
Copy link
Member Author

rhc54 commented Jun 13, 2025

Please use emoji reactions ON THIS COMMENT to indicate your position on this proposal.

  • You do not need to vote on every proposal
  • If you have no opinion, don't vote - that is also useful data
  • If you've already commented on this issue, please still vote so
    we know your current thoughts
  • Not all proposals solve exactly the same problem, so we may end
    up accepting proposals that appear to have some overlap
    This is not a binding majority-rule vote, but it will be a very
    significant input into the corresponding ASC decision.

Here are the meanings for the emojis:

  • Hooray or Rocket: I support this so strongly that I
    want to be an advocate for it
  • Heart: I think this is an ideal solution
  • Thumbs up: I'd be happy with this solution
  • Confused: I'd rather we not do this, but I can tolerate it
  • Thumbs down: I'd be actively unhappy, and may even consider
    other technologies instead
    If you want to explain in more detail, feel free to add another
    comment, but please also vote on this comment.

Server upcall functions were required to return prior to executing
the callback function. This was a limitation of the implementation
and not a requirement of the Standard - the statements should
never have been included here.

FWIW: the limitation has subsequently been removed from the
reference implementation.

In the pmix_server_iof_fn_t, clarify that an error status can be
returned either directly by the function or in the callback function.
It does not require that the host execute the callback to return
an error, as was implied by the current language.

Signed-off-by: Ralph Castain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant