-
Notifications
You must be signed in to change notification settings - Fork 22
Errata: fix a couple of spots in server upcall functions #523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please use emoji reactions ON THIS COMMENT to indicate your position on this proposal.
Here are the meanings for the emojis:
|
Server upcall functions were required to return prior to executing the callback function. This was a limitation of the implementation and not a requirement of the Standard - the statements should never have been included here. FWIW: the limitation has subsequently been removed from the reference implementation. In the pmix_server_iof_fn_t, clarify that an error status can be returned either directly by the function or in the callback function. It does not require that the host execute the callback to return an error, as was implied by the current language. Signed-off-by: Ralph Castain <[email protected]>
Note for when merging, we will need to add a changelog errata entry |
While this seem to cover all such mentions in Server-Specific Interfaces section, I found a few more also in other parts:
Furthermore a similar sentence is in one of the commands:
This one is used at several places all over the document including in the Server-Specific Interfaces section. Unclear to me if we want to handle them in this PR or if this would be a new issue. |
In the Revision History section for version 2.1 it is stated:
Thus, it seems there was a clear intention at that time. Do we have to explain why we have a different view on this now? |
We'll note that we changed it in the revision history. Probably have a little blurb, but nothing too verbose. Just didn't want to include it here as the revision history for v6 is created in a different PR - no need to maximize conflict. |
I can fix them here - thanks for spotting them! |
Signed-off-by: Ralph Castain <[email protected]>
@neicker I fixed the places you mentioned. See if they now look okay. |
Looks good to me. |
2025 ASC Q3 Voting Result: Passed (9 Yes, 0 No, 0 Abstain) |
Server upcall functions were required to return prior to executing the callback function. This was a limitation of the implementation and not a requirement of the Standard - the statements should never have been included here.
FWIW: the limitation has subsequently been removed from the reference implementation.
In the pmix_server_iof_fn_t, clarify that an error status can be returned either directly by the function or in the callback function. It does not require that the host execute the callback to return an error, as was implied by the current language.