Fix a few minor issues with CMakeLists.txt #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This variable is not defined anywhere in Chromobius and does not exist in Pymatching, so it has no value and no effect in this CMakeLists.txt file.
The `CMakeLists.txt file had this in it:
```cmake
add_compile_definitions(CHROMOBIUS_VERSION_INFO=${CHROMOBIUS_VERSION_INFO})
```
However, the variable on the RHS (`CHROMOBIUS_VERSION_INFO`) is not set
when CMake is processing the file.
The new code extracts the version number from the `setup.py` file and
sets the variable before the `add_compile_definitions()` statement.
This wraps some of the very long lines to stay within the 120 column length used in the C++ files, and normalizes indentation to 4 spaces.
mhucka
changed the title
Strilanc
approved these changes
Oct 24, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mhucka
added a commit
that referenced
this pull request
Dec 1, 2025
This does a minor cleanup of a few issues with `CMakeLists.txt`:
* Remove references to variable `PYMATCHING_SOURCE_FILES_NO_MAIN`. This
variable is not defined anywhere in Chromobius and does not exist in
Pymatching, so as far as I can tell, its value is always empty and thus
has no effect in this `CMakeLists.txt` file.
* Set variable `CHROMOBIUS_VERSION_INFO` from `setup.py`. Previously,
the `CMakeLists.txt` file had this in it:
```cmake
add_compile_definitions(CHROMOBIUS_VERSION_INFO=${CHROMOBIUS_VERSION_INFO})
```
However, the variable on the RHS (`${CHROMOBIUS_VERSION_INFO}`) is not
set when CMake is processing the file. This PR changes it to extract the
version number from the `setup.py` file.
* Wrap long lines and normalize indentation to 4 spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a minor cleanup of a few issues with
CMakeLists.txt:Remove references to variable
PYMATCHING_SOURCE_FILES_NO_MAIN. This variable is not defined anywhere in Chromobius and does not exist in Pymatching, so as far as I can tell, its value is always empty and thus has no effect in thisCMakeLists.txtfile.Set variable
CHROMOBIUS_VERSION_INFOfromsetup.py. Previously, theCMakeLists.txtfile had this in it:However, the variable on the RHS (
${CHROMOBIUS_VERSION_INFO}) is not set when CMake is processing the file. This PR changes it to extract the version number from thesetup.pyfile.Wrap long lines and normalize indentation to 4 spaces.