-
Notifications
You must be signed in to change notification settings - Fork 0
Conditionally render spares 1591 #1599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1599 +/- ##
=========================================
Coverage 98.82% 98.82%
=========================================
Files 111 111
Lines 21769 21790 +21
Branches 3487 2508 -979
=========================================
+ Hits 21514 21535 +21
- Misses 250 254 +4
+ Partials 5 1 -4 ☔ View full report in Codecov by Sentry. |
db1dfba to
0618ac4
Compare
0618ac4 to
3719ebc
Compare
joelvdavies
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working well for me, just two very minor suggestions.
Co-authored-by: Joel Davies <[email protected]>
Description
Only render spares information if spares definition is defined everywhere bar the settings
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
closes #1591