Skip to content

Conversation

@joshdimanteto
Copy link
Contributor

Description

Only render spares information if spares definition is defined everywhere bar the settings

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage
  • {more steps here}

Agile board tracking

closes #1591

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.82%. Comparing base (ae65126) to head (5c4afcf).
⚠️ Report is 1 commits behind head on develop.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop    #1599    +/-   ##
=========================================
  Coverage    98.82%   98.82%            
=========================================
  Files          111      111            
  Lines        21769    21790    +21     
  Branches      3487     2508   -979     
=========================================
+ Hits         21514    21535    +21     
- Misses         250      254     +4     
+ Partials         5        1     -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshdimanteto joshdimanteto force-pushed the conditionally-render-spares-1591 branch from db1dfba to 0618ac4 Compare November 13, 2025 10:45
@joshdimanteto joshdimanteto force-pushed the conditionally-render-spares-1591 branch from 0618ac4 to 3719ebc Compare November 13, 2025 11:05
Base automatically changed from create-api-config-provider-#1595 to develop November 13, 2025 11:07
@joshdimanteto joshdimanteto marked this pull request as ready for review November 13, 2025 12:34
Copy link
Contributor

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well for me, just two very minor suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conditionally render the spares number

3 participants