added time_from_start to action feedback #1756
Open
+25
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how easy this will be to backport to humble, but here it the PR that I tested on humble
The JTC does not publish the desired time_from_start in the feedback topic.
I wish to build a action client that monitors the progress of the trajectory, and has the ability to resume a partially completed trajectory. For this reason, I need the time_from_start feedback.
This PR populates the time_from_start element of the feedback message with the desired time_from_start
To send us a pull request, please:
colcon test
andpre-commit run
(requires you to install pre-commit bypip3 install pre-commit
)