m1_merge_candidate_v2 does not build on Kinetic

[VictorLamoine]

Am I missing anything?

/home/victor/code/catkin_workspace/src/CAD-to-ROS/urdf_editor/src/link_collision_property.cpp: In constructor ‘urdf_editor::LinkCollisionProperty::LinkCollisionProperty(urdf::CollisionSharedPtr)’:
/home/victor/code/catkin_workspace/src/CAD-to-ROS/urdf_editor/src/link_collision_property.cpp:27:55: error: ‘class urdf::Collision’ has no member named ‘group_name’
     item->setValue(QString::fromStdString(collision_->group_name));
                                                       ^~~~~~~~~~
/home/victor/code/catkin_workspace/src/CAD-to-ROS/urdf_editor/src/link_collision_property.cpp: In member function ‘void urdf_editor::LinkCollisionProperty::loadData()’:
/home/victor/code/catkin_workspace/src/CAD-to-ROS/urdf_editor/src/link_collision_property.cpp:123:59: error: ‘class urdf::Collision’ has no member named ‘group_name’
         item->setValue(QString::fromStdString(collision_->group_name));
                                                           ^~~~~~~~~~
/home/victor/code/catkin_workspace/src/CAD-to-ROS/urdf_editor/src/link_collision_property.cpp: In member function ‘void urdf_editor::LinkCollisionProperty::onValueChanged(QtProperty*, const QVariant&)’:
/home/victor/code/catkin_workspace/src/CAD-to-ROS/urdf_editor/src/link_collision_property.cpp:153:19: error: ‘class urdf::Collision’ has no member named ‘group_name’
       collision_->group_name = val.toString().toStdString();
                   ^~~~~~~~~~
CAD-to-ROS/urdf_editor/CMakeFiles/urdf_editor.dir/build.make:1068 : la recette pour la cible « CAD-to-ROS/urdf_editor/CMakeFiles/urdf_editor.dir/src/link_collision_property.cpp.o » a échouée
make[2]: *** [CAD-to-ROS/urdf_editor/CMakeFiles/urdf_editor.dir/src/link_collision_property.cpp.o] Erreur 1
make[2]: *** Attente des tâches non terminées....
/home/victor/code/catkin_workspace/src/CAD-to-ROS/urdf_editor/src/utils/convex_hull_generator.cpp: In member function ‘bool urdf_editor::utils::ConvexHullGenerator::save(const string&)’:
/home/victor/code/catkin_workspace/src/CAD-to-ROS/urdf_editor/src/utils/convex_hull_generator.cpp:67:50: error: invalid conversion from ‘void (*)(const char*, Assimp::IOSystem*, const aiScene*)’ to ‘Assimp::Exporter::fpExportFunc {aka void (*)(const char*, Assimp::IOSystem*, const aiScene*, const Assimp::ExportProperties*)}’ [-fpermissive]
                                            "stl",&assimp::STLExporter::ExportSceneSTLBinary,
                                                  ^~~~~~~
In file included from /home/victor/code/catkin_workspace/src/CAD-to-ROS/urdf_editor/include/urdf_editor/utils/convex_hull_generator.h:6:0,
                 from /home/victor/code/catkin_workspace/src/CAD-to-ROS/urdf_editor/src/utils/convex_hull_generator.cpp:1:
/usr/include/assimp/Exporter.hpp:103:9: note:   initializing argument 4 of ‘Assimp::Exporter::ExportFormatEntry::ExportFormatEntry(const char*, const char*, const char*, Assimp::Exporter::fpExportFunc, unsigned int)’
         ExportFormatEntry( const char* pId, const char* pDesc, const char* pExtension, fpExportFunc pFunction, unsigned int pEnforcePP = 0u)
         ^~~~~~~~~~~~~~~~~
CAD-to-ROS/urdf_editor/CMakeFiles/urdf_editor.dir/build.make:828 : la recette pour la cible « CAD-to-ROS/urdf_editor/CMakeFiles/urdf_editor.dir/src/utils/convex_hull_generator.cpp.o » a échouée
make[2]: *** [CAD-to-ROS/urdf_editor/CMakeFiles/urdf_editor.dir/src/utils/convex_hull_generator.cpp.o] Erreur 1
CMakeFiles/Makefile2:11689 : la recette pour la cible « CAD-to-ROS/urdf_editor/CMakeFiles/urdf_editor.dir/all » a échouée
make[1]: *** [CAD-to-ROS/urdf_editor/CMakeFiles/urdf_editor.dir/all] Erreur 2
Makefile:138 : la recette pour la cible « all » a échouée
make: *** [all] Erreur 2

[gavanderhoorn]

I haven't built this myself recently, and also not on Kinetic. I can well imagine that we suffer from some bit-rot here.

The urdf packages have seen some development in mainline ros, so I wouldn't be surprised if some things have changed.

I won't have time to look into this this week, but perhaps someone else can step in.