Adds tests to software watchdogs #11
Conversation
norro
commented
Apr 13, 2021
norro
commented
- Basic testing and linting
- Launch tests for sw_watchdog package Add unit tests to watchdog repository safety_working_group#28 Add coverage to the watchdogs repository safety_working_group#30
Signed-off-by: Nordmann Arne (CR/ADT3) <[email protected]>
* Enables basic testing, linting * Fixes code style and linting Signed-off-by: Nordmann Arne (CR/ADT3) <[email protected]>
norro
force-pushed
the
testing
branch
2 times, most recently
from
1be1bc2
to
21647ce
Compare
|
Sorry for the large PR. Once I activated testing, I had to do a lot of linting first. The only semantic change is 85a6200, adding a launch test that
|
norro
force-pushed
the
testing
branch
2 times, most recently
from
93de1ce
to
8c4dbf1
Compare
* Talker, heartbeat, and watchdog are launched * When heartbeat and watchdog are in sync, heartbeat and talker are shut down * Proper reaction by watchdog (going nactive) is monitored ros-safety/safety_working_group#28 ros-safety/safety_working_group#30 Signed-off-by: Nordmann Arne (CR/ADT3) <[email protected]>
| # ) | ||
| # endif() | ||
| if(BUILD_TESTING) | ||
| find_package(ament_lint_auto REQUIRED) |
There was a problem hiding this comment.
I don't think ament_lint can lint message files.
There was a problem hiding this comment.
You are probably right. I took the cmake configuration from lifecycle_msgs, though, as I thought being a quality level 1 package this probably knows what it's doing. :D
| @@ -16,8 +16,6 @@ | |||
|
|
|||
| <test_depend>ament_lint_auto</test_depend> | |||
| <test_depend>ament_lint_common</test_depend> | |||
| <test_depend>ros_testing</test_depend> | |||
There was a problem hiding this comment.
What specifically is being tested?
There was a problem hiding this comment.
I removed ros_testing from the dependencies because there were no node tests in sw_watchdog_msgs. I think it won't test much for this package except standard things like manifest and copyright.
Signed-off-by: Nordmann Arne (CR/ADT3) <[email protected]>
Signed-off-by: Nordmann Arne (CR/ADT3) <[email protected]>
