Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support roslaunch parameters in static_transform_publisher #110

Open
wants to merge 2 commits into
base: indigo-devel
Choose a base branch
from

Conversation

orzechow
Copy link

@orzechow orzechow commented Nov 5, 2015

eg. to enable using already loaded parameters as arguments:

<node pkg="tf" type="static_transform_publisher" name="static_tf_broadcaster1" respawn="true" >
  <remap from="~/x" to="/foo/bar"/>
  <param name="y" type="double" value="0.0" />
  <param name="z" type="double" value="0.0" />
  <param name="frame_id" type="string" value="link1_parent" />
  <param name="child_frame_id" type="string" value="link1" />
  <param name="period" type="double" value="100" />
  <param name="yaw" type="double" value="0.0" />
  <param name="pitch" type="double" value="0.0" />
  <param name="roll" type="double" value="0.0" />
</node>

@tfoote
Copy link
Member

tfoote commented Nov 5, 2015

Thanks this looks good overall. If we're revisiting this command I'd like to make the same changes to https://github.com/ros/geometry_experimental/blob/jade-devel/tf2_ros/src/static_transform_broadcaster_program.cpp and possibly reuse the functionality from that program here as that approach is much lower bandwidth.

@orzechow
Copy link
Author

orzechow commented Nov 5, 2015

Sure! I didn't know which package to choose, so decided for tf.
But this change fits to both obviously.

Am 06.11.2015 um 00:11 schrieb Tully Foote [email protected]:

Thanks this looks good overall. If we're revisiting this command I'd like to make the same changes to https://github.com/ros/geometry_experimental/blob/jade-devel/tf2_ros/src/static_transform_broadcaster_program.cpp and possibly reuse the functionality from that program here as that approach is much lower bandwidth.


Reply to this email directly or view it on GitHub.

@tfoote
Copy link
Member

tfoote commented Jul 15, 2017

@ros-pull-request-builder retest this please

1 similar comment
@tfoote
Copy link
Member

tfoote commented Jul 24, 2017

@ros-pull-request-builder retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants