Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iron Backport of #720 #724

Open
wants to merge 2 commits into
base: iron
Choose a base branch
from
Open

Iron Backport of #720 #724

wants to merge 2 commits into from

Conversation

CursedRock17
Copy link
Contributor

Iron "Backport" of #720 in which we added .hpp versions of the .h files in tf2, but without the warning message to get backwards compatibility and prevent weird syntax like this:

#if __has_include(<cv_bridge/cv_bridge.hpp>)
#include <cv_bridge/cv_bridge.hpp> // for ROS 2 Jazzy or newer
#else
#include <cv_bridge/cv_bridge.h> // for ROS 2 Humble or older
#endif

@CursedRock17
Iron Backport of ros2#720
04e7636 
Signed-off-by: CursedRock17 <[email protected]>

Iron Backport of ros2#720

Signed-off-by: CursedRock17 <[email protected]>
@CursedRock17 CursedRock17 mentioned this pull request Oct 31, 2024
Open
@CursedRock17
Removing whitespace
d8ab09c 
Signed-off-by: CursedRock17 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde Awaiting requested review from ahcorde ahcorde is a code owner

@clalancette clalancette Awaiting requested review from clalancette clalancette is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CursedRock17