Skip to content

chore: eslint cleanup and code changes accordingly #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

BlankParticle
Copy link
Member

@BlankParticle BlankParticle commented Jul 21, 2024

What does this PR do?

Setup Eslint properly in the Project and make code changes accordingly.
Please don't merge until the open PRs are merged and this branch is rebased on them

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

Required

  • Read Contributing Guide
  • Self-reviewed my own code
  • Tested my code in a local environment
  • Commented on my code in hard-to-understand areas
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the UnInbox Docs if changes were necessary

Copy link
Member Author

BlankParticle commented Jul 21, 2024

@BlankParticle BlankParticle added the enhancement New feature or request label Jul 21, 2024 — with Graphite App
@BlankParticle BlankParticle force-pushed the chore/eslint-cleanup-and-changes branch 4 times, most recently from 830f761 to 15b14e4 Compare July 28, 2024 05:29
@BlankParticle BlankParticle changed the base branch from main to blank/feat/convo-list-updater July 28, 2024 05:30
@BlankParticle BlankParticle marked this pull request as ready for review July 28, 2024 05:33
@CLAassistant
Copy link

CLAassistant commented Jul 28, 2024

CLA assistant check
All committers have signed the CLA.

@BlankParticle BlankParticle force-pushed the chore/eslint-cleanup-and-changes branch from fb532e1 to d6cf29b Compare July 28, 2024 05:38
@BlankParticle BlankParticle force-pushed the blank/feat/convo-list-updater branch from 429d350 to b2253a0 Compare July 28, 2024 05:55
@BlankParticle BlankParticle force-pushed the chore/eslint-cleanup-and-changes branch from d6cf29b to 75ef741 Compare July 28, 2024 05:56
@BlankParticle BlankParticle force-pushed the blank/feat/convo-list-updater branch from b2253a0 to c2a530d Compare July 28, 2024 06:09
@BlankParticle BlankParticle force-pushed the chore/eslint-cleanup-and-changes branch from 75ef741 to 3ae469d Compare July 28, 2024 06:09
@BlankParticle BlankParticle force-pushed the blank/feat/convo-list-updater branch from c2a530d to 6ca563c Compare July 28, 2024 06:30
@BlankParticle BlankParticle force-pushed the chore/eslint-cleanup-and-changes branch from 3ae469d to 253468d Compare July 28, 2024 06:30
@OmarMcAdam OmarMcAdam force-pushed the blank/feat/convo-list-updater branch from 6ca563c to 705307a Compare July 28, 2024 14:43
@BlankParticle BlankParticle force-pushed the blank/feat/convo-list-updater branch from 705307a to 818f447 Compare July 28, 2024 15:02
@BlankParticle BlankParticle force-pushed the chore/eslint-cleanup-and-changes branch from 253468d to fad6bc3 Compare July 28, 2024 15:02
@OmarMcAdam OmarMcAdam force-pushed the chore/eslint-cleanup-and-changes branch from fad6bc3 to b2c4206 Compare July 28, 2024 15:06
@BlankParticle BlankParticle changed the base branch from blank/feat/convo-list-updater to main July 28, 2024 15:06
@BlankParticle BlankParticle merged commit d9ab8ce into main Jul 28, 2024
2 checks passed
Copy link
Member Author

Merge activity

@BlankParticle BlankParticle deleted the chore/eslint-cleanup-and-changes branch July 28, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants