Skip to content

feat: fixing every little annoying issue #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

BlankParticle
Copy link
Member

@BlankParticle BlankParticle commented Jul 27, 2024

What does this PR do?

This PR started as a fix for updating the convo cache.
While doing that I ran into many issues, this PR fixes every issue I ran into.
Here is a list of everything I fixed and remember:

  • Whole UI is now synced with the data in while sending/receiving messages
  • removed every last instance of useLoading in favour of better useMutation
  • Shift key now skips delete modal
  • FIxed message/convo list flicker issues while scrolling and making new convos
  • Fixed Most of the Overflow bugs in Desktop mode
  • Sent attachments are now cleared after a message/comment is sent
  • Attachment list, last update time of convo is now updated properly
  • useTimeAgo is now more smart and optimal
  • User Profile now uses a form instead of useState hell
  • Tooltip on theme changer
  • Fix background less image avatars
  • etc...

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

Required

  • Read Contributing Guide
  • Self-reviewed my own code
  • Tested my code in a local environment
  • Commented on my code in hard-to-understand areas
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the UnInbox Docs if changes were necessary

Copy link
Member Author

BlankParticle commented Jul 27, 2024

@BlankParticle BlankParticle changed the title feat: Better convo list updater feat: fixing every little annoying issue Jul 27, 2024
@BlankParticle BlankParticle marked this pull request as ready for review July 27, 2024 18:28
@BlankParticle BlankParticle force-pushed the blank/feat/convo-list-updater branch from 35a7c6f to 438d1d9 Compare July 27, 2024 18:51
@BlankParticle BlankParticle force-pushed the blank/feat/new-securtiy-workflow branch from e1e7c57 to 901a734 Compare July 27, 2024 18:52
@BlankParticle BlankParticle force-pushed the blank/feat/convo-list-updater branch from 438d1d9 to 1797715 Compare July 27, 2024 18:52
@OmarMcAdam OmarMcAdam force-pushed the blank/feat/convo-list-updater branch from 1797715 to 429d350 Compare July 27, 2024 19:35
@graphite-app graphite-app bot changed the base branch from blank/feat/new-securtiy-workflow to main July 27, 2024 19:35
@BlankParticle BlankParticle force-pushed the blank/feat/convo-list-updater branch 3 times, most recently from c2a530d to 6ca563c Compare July 28, 2024 06:30
@OmarMcAdam OmarMcAdam force-pushed the blank/feat/convo-list-updater branch from 6ca563c to 705307a Compare July 28, 2024 14:43
Copy link
Member

@OmarMcAdam OmarMcAdam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes discussed in discord

@BlankParticle BlankParticle force-pushed the blank/feat/convo-list-updater branch from 705307a to 818f447 Compare July 28, 2024 15:02
@OmarMcAdam OmarMcAdam merged commit 9787b88 into main Jul 28, 2024
5 checks passed
Copy link
Member

Merge activity

  • Jul 28, 11:06 AM EDT: @McPizza0 merged this pull request with Graphite.

@BlankParticle BlankParticle deleted the blank/feat/convo-list-updater branch July 28, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants