-
Notifications
You must be signed in to change notification settings - Fork 123
feat: fixing every little annoying issue #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @BlankParticle and the rest of your teammates on |
35a7c6f
to
438d1d9
Compare
e1e7c57
to
901a734
Compare
438d1d9
to
1797715
Compare
1797715
to
429d350
Compare
16 tasks
c2a530d
to
6ca563c
Compare
This was referenced Jul 28, 2024
6ca563c
to
705307a
Compare
OmarMcAdam
requested changes
Jul 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes discussed in discord
705307a
to
818f447
Compare
OmarMcAdam
approved these changes
Jul 28, 2024
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR started as a fix for updating the convo cache.
While doing that I ran into many issues, this PR fixes every issue I ran into.
Here is a list of everything I fixed and remember:
useLoading
in favour of betteruseMutation
useTimeAgo
is now more smart and optimaluseState
hellType of change
Checklist
Required
console.logs
git pull origin main
Appreciated