Skip to content

chore: load opentelemetry modules on demand #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

BlankParticle
Copy link
Member

@BlankParticle BlankParticle commented Jul 28, 2024

What does this PR do?

Opentelemetry Modules are now dynamically imported based on the env variable. This makes sure that opentelemetry doesn't get loaded into apps if it is disabled

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

Required

  • Read Contributing Guide
  • Self-reviewed my own code
  • Tested my code in a local environment
  • Commented on my code in hard-to-understand areas
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the UnInbox Docs if changes were necessary

Copy link
Member Author

BlankParticle commented Jul 28, 2024

@BlankParticle BlankParticle marked this pull request as ready for review July 28, 2024 12:33
@BlankParticle BlankParticle force-pushed the blank/chore/remove-unused-checks-and-code branch from 4e45010 to f70c80a Compare July 28, 2024 15:02
@BlankParticle BlankParticle force-pushed the blank/chore/dynamicly-load-opentelemetry branch from fb0b52d to 6951d54 Compare July 28, 2024 15:02
@OmarMcAdam OmarMcAdam force-pushed the blank/chore/remove-unused-checks-and-code branch from f70c80a to 2fb8be2 Compare July 28, 2024 15:07
@OmarMcAdam OmarMcAdam force-pushed the blank/chore/dynamicly-load-opentelemetry branch from 6951d54 to 3371a01 Compare July 28, 2024 15:07
@BlankParticle BlankParticle force-pushed the blank/chore/remove-unused-checks-and-code branch from 2fb8be2 to 79db630 Compare July 28, 2024 15:09
@BlankParticle BlankParticle force-pushed the blank/chore/dynamicly-load-opentelemetry branch from 3371a01 to 7ab1313 Compare July 28, 2024 15:09
@BlankParticle BlankParticle force-pushed the blank/chore/dynamicly-load-opentelemetry branch from 7ab1313 to d6a49cb Compare July 28, 2024 15:10
@graphite-app graphite-app bot changed the base branch from blank/chore/remove-unused-checks-and-code to main July 28, 2024 15:10
@BlankParticle BlankParticle merged commit ab0145c into main Jul 28, 2024
3 checks passed
Copy link
Member Author

Merge activity

@BlankParticle BlankParticle deleted the blank/chore/dynamicly-load-opentelemetry branch July 28, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants