-
-
Notifications
You must be signed in to change notification settings - Fork 668
test: show effect of checking for same dimension and stacked field in polar and cartesian fields #9537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
hydrosquall
wants to merge
10
commits into
cameron.yick/fix-compile-pie-stack
Choose a base branch
from
cameron.yick/fix-compile-cartesian-stack
base: cameron.yick/fix-compile-pie-stack
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying vega-lite with
|
| Latest commit: |
231ed17
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://47451acb.vega-lite.pages.dev |
| Branch Preview URL: | https://cameron-yick-fix-compile-car.vega-lite.pages.dev |
518f6ab to
cd5a691
Compare
…el and stackChannel are same
…hannels are matching
ca62a23 to
2ebd1b1
Compare
8b010a6 to
4d8cf8b
Compare
d8b3ab4 to
c5eae62
Compare
|
@hydrosquall are you still working on this? |
|
This is just a proof of concept to compare with
#9512 (comment) . I
plan to close it when/if the upstream is resolved.
…On Thu, Jul 3, 2025 at 8:41 AM Dominik Moritz ***@***.***> wrote:
*domoritz* left a comment (vega/vega-lite#9537)
<#9537 (comment)>
@hydrosquall <https://github.com/hydrosquall> are you still working on
this?
—
Reply to this email directly, view it on GitHub
<#9537 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACE2MMZOXDHUSMAWIF5U2CD3GUQFZAVCNFSM6AAAAABXNF6ADKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAMZSGEZDEMBVGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
quantitativedefinitions when different fields are used forthetaandradius[draft] #9512 (comment)