Fix: Eslint ignore pattern #295
Conversation
The commit fixes several TypeScript-related issues, improves type safety, and makes type usage more consistent across multiple components. This includes proper HTMLAttributes usage, explicit HTMLTag typing, and better Props type definitions.
Deploying head-start with
|
| Latest commit: |
705e77a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fa8dc93a.head-start.pages.dev |
| Branch Preview URL: | https://fix-eslint-ignore-pattern.head-start.pages.dev |
| @@ -6,7 +6,7 @@ interface Props { | |||
| } | |||
| const { node } = Astro.props; | |||
|
|
|||
| node; | |||
| void node; | |||
There was a problem hiding this comment.
I thought this one was interesting.
The fix I applied changes
node;tovoid node;. Thevoidoperator explicitly indicates that you're intentionally discarding the value, which satisfies the@typescript-eslint/no-unused-expressionsrule while still preventing the unused variable warning.
So does that mean that we can just leave it out or do we want to keep it?
There was a problem hiding this comment.
I don't get it tbh, why is the comment talking about Svelte? Got not enough Astro experience for this :)
There was a problem hiding this comment.
I think this component could just be a <hr /> tag, but I'll leave it for now.
| @@ -6,7 +6,7 @@ interface Props { | |||
| } | |||
| const { node } = Astro.props; | |||
|
|
|||
| node; | |||
| void node; | |||
There was a problem hiding this comment.
I don't get it tbh, why is the comment talking about Svelte? Got not enough Astro experience for this :)
folder pattern
Changes
Associated issue
N.A.
How to test
Check first commit. There you'll see changing the pattern causes errors in de workflow.
See the changed files. Check if linter successful.
Checklist
I have made updated relevant documentation files (in project README, docs/, etc)I have added a decision log entry if the change affects the architecture or changes a significant technology