Skip to content

fix: resend code timer [WPB-18364] #4145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 4, 2025

Conversation

sbakhtiarov
Copy link
Contributor

@sbakhtiarov sbakhtiarov commented Jul 24, 2025

BugWPB-18364 [Android]Resend code button on verification screen of Next-Column-3 is not clickable

https://wearezeta.atlassian.net/browse/WPB-18364

What's new in this PR?

Issues

"Resend Code" button allows user to request 2FA codes more frequent than allowed by server rate limitation.

Solutions

Disable "Resend Code" button for 5 minutes after requesting 2FA code.

resend_code_timer

Copy link

codecov bot commented Jul 24, 2025

Codecov Report

❌ Patch coverage is 26.82927% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.84%. Comparing base (858baba) to head (4de7ad0).

Files with missing lines Patch % Lines
...tication/create/code/CreateAccountCodeViewModel.kt 0.00% 12 Missing ⚠️
.../kotlin/com/wire/android/util/ui/CountdownTimer.kt 0.00% 9 Missing ⚠️
...cation/devices/register/RegisterDeviceViewModel.kt 55.55% 4 Missing ⚠️
.../authentication/login/email/LoginEmailViewModel.kt 55.55% 4 Missing ⚠️
...tication/create/code/CreateAccountCodeViewState.kt 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (26.82%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #4145      +/-   ##
=====================================================
- Coverage              45.88%   45.84%   -0.04%     
=====================================================
  Files                    492      493       +1     
  Lines                  17217    17256      +39     
  Branches                2872     2878       +6     
=====================================================
+ Hits                    7900     7911      +11     
- Misses                  8515     8543      +28     
  Partials                 802      802              
Files with missing lines Coverage Δ
...tication/verificationcode/VerificationCodeState.kt 100.00% <100.00%> (ø)
...tication/create/code/CreateAccountCodeViewState.kt 0.00% <0.00%> (ø)
...cation/devices/register/RegisterDeviceViewModel.kt 75.00% <55.55%> (-1.85%) ⬇️
.../authentication/login/email/LoginEmailViewModel.kt 76.15% <55.55%> (-1.31%) ⬇️
.../kotlin/com/wire/android/util/ui/CountdownTimer.kt 0.00% <0.00%> (ø)
...tication/create/code/CreateAccountCodeViewModel.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 858baba...4de7ad0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Built wire-android-staging-compat-pr-4145.apk is available for download

Copy link
Contributor

Built wire-android-staging-compat-pr-4145.apk is available for download

@sbakhtiarov sbakhtiarov requested a review from saleniuk July 28, 2025 12:02
Copy link
Contributor

Built wire-android-staging-compat-pr-4145.apk is available for download

@sbakhtiarov sbakhtiarov requested a review from ohassine July 30, 2025 07:10
Copy link

sonarqubecloud bot commented Aug 4, 2025

@sbakhtiarov sbakhtiarov added this pull request to the merge queue Aug 4, 2025
Copy link
Contributor

github-actions bot commented Aug 4, 2025

Built wire-android-staging-compat-pr-4145.apk is available for download

Merged via the queue into release/candidate with commit 9e1e6a8 Aug 4, 2025
13 of 14 checks passed
@sbakhtiarov sbakhtiarov deleted the fix/resend-code-timer branch August 4, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants