-
Notifications
You must be signed in to change notification settings - Fork 41
fix: resend code timer [WPB-18364] #4145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (26.82%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## release/candidate #4145 +/- ##
=====================================================
- Coverage 45.88% 45.84% -0.04%
=====================================================
Files 492 493 +1
Lines 17217 17256 +39
Branches 2872 2878 +6
=====================================================
+ Hits 7900 7911 +11
- Misses 8515 8543 +28
Partials 802 802
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
app/src/main/kotlin/com/wire/android/ui/authentication/verificationcode/ResendCodeText.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/wire/android/ui/authentication/verificationcode/ResendCodeText.kt
Show resolved
Hide resolved
Built wire-android-staging-compat-pr-4145.apk is available for download |
Built wire-android-staging-compat-pr-4145.apk is available for download |
Built wire-android-staging-compat-pr-4145.apk is available for download |
|
Built wire-android-staging-compat-pr-4145.apk is available for download |
https://wearezeta.atlassian.net/browse/WPB-18364
What's new in this PR?
Issues
"Resend Code" button allows user to request 2FA codes more frequent than allowed by server rate limitation.
Solutions
Disable "Resend Code" button for 5 minutes after requesting 2FA code.