[UR][CUDA] Fix command-buffer handle inheritance #18457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ur_exp_command_buffer_handle_t_` definition in the CUDA adapter was missed in intel#17118 in the changes to inherit from a base handle. Discovered by seeing segfaults in the UR CTS tests locally, and git bisecting back to that change.
EwanC
force-pushed
the
ewan/fix_cuda_ur_command-buffer
branch
from
9939613 to
bbe079a
Compare
konradkusiak97
approved these changes
May 14, 2025
|
@intel/llvm-gatekeepers Can we merge this please? The CI failing config is for Arc, however this is a CUDA only change. |
|
Created an issue to for the failing Arc tests here as they failed on another PR #18463 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ur_exp_command_buffer_handle_t_definition in the CUDA adapter was missed in #17118 in the changes to inherit from a base handle.Discovered by seeing segfaults in the UR CTS tests locally, and git bisecting back to that change.