-
Notifications
You must be signed in to change notification settings - Fork 0
build(nix): create variant launch files #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
what if we create a branch called |
Sounds good; the only issue would be that it might get a bit annoying to constantly merge the latest changes onto this branch. The Nix build files can actually be recreated with a simple command from the If you think this wouldn't disrupt the codebase at all, I think the best option would be to merge into main. Otherwise, if this might introduce too much confusion/technical debt, you can just close this PR and the arcturus-nix setup will still work fine. |
Wait nvm this is the PR for creating variant launch files, not package declarations. These files cannot be auto-generated, so the two options would be to keep this on a separate branch or merge into main. I would prefer merging into main, but this might add additional confusion and duplicate code, so if you think it would be better to put this on a separate branch for now, that's fine as well. |
365a4fb
to
e16e44c
Compare
@toyat522 @wellscrosby @JanelleCai ready for review; this doesn't change any of the main codebase but adds continuous integration using the Nix build system to check that every commit to main does not break any of the modules (can be extended to include more complex tests later). This PR also adds new launch files for testing purposes (doesn't affect existing launch files) and a pre commit hook for Nix users (shouldn't affect Docker workflow). |
7dc5e05
to
b220bf3
Compare
6b8fa92
to
a9331c2
Compare
This PR adds three variant launch files intended for testing a Nix migration in production: