AP_Scripting: add a simple serial dump script #28912
Conversation
the existing example seems to do *way* too much work so has trouble capturing at higher baud rates.
peterbarker
force-pushed
the
pr/simple-serial-dump
branch
from
cdd49b8 to
c949077
Compare
|
Ports have |
| if c == nil then | ||
| break | ||
| end | ||
| file:write(string.char()) |
There was a problem hiding this comment.
| file:write(string.char()) | |
| file:write(string.char(c)) |
There was a problem hiding this comment.
Question.
How was this working with this problem in here?!
The data coming out looked valid to me (it's in my LD06 PR).
There was a problem hiding this comment.
I don't know, that would imply a really interesting bug in the Lua interpreter. I couldn't find the PR you mentioned, but I assume you fixed it and forgot to update the code in Git.
Also read returns -1 on error, not nil.
And it's strange to open and close the file every loop. Probably better to simply flush it every n loops.
And c should be local...
I'm guessing we're not running that.... |
|
We could potentially look to see if we have the readstring binding and use it if available, 'though. I'll need to remove "Simple" from the script name then.... |
the existing example seems to do way too much work so has trouble capturing at higher baud rates.