AP_Mount: add CADDX gimbal support #28942
Open
+248
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Randy Mackay <[email protected]>
rmackay9
force-pushed
the
caddx-mount-serial
branch
from
df038ba to
358d493
Compare
|
why drop the lock types and control? |
|
Hi @Hwurzburg, I dropped the lock types and control because I couldn't get them to work and also they are really an enhancement so they naturally fall into a follow-up PR that could potentially affect other gimbals as well. The Siyi gimbal for example also supports FPV mode and users have been asking for that for a long time so we could do the two together |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simplified version of @Hwurzburg's previous PR #28373 to add support for the CADDX GM3 gimbal
This simply adds support for the gimbal without trying to support the extra lock types that the gimbal provides. These extra lock types add the ability to control each axis (roll, pitch and yaw) in earth or body frame independently. For example roll control could be in body frame while pitch is in earth frame. This new ability is not supported in this PR.
This has been tested on real hardware and seems OK.
The corresponding wiki PR is here ArduPilot/ardupilot_wiki#6441