Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Mother of All BLHeli Passthrough Fixes #29590

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

andyp1per
Copy link
Collaborator

@andyp1per andyp1per commented Mar 22, 2025

soft serial input was both racy and prone to resetting the line mode incorrectly.
soft serial input was decoding input with trailing 1's incorrectly
soft serial input could miss data when timing out and restarting
DMA output could be left in a bad state

@andyp1per andyp1per added the BUG label Mar 22, 2025
@timtuxworth
Copy link
Contributor

lol

@andyp1per andyp1per force-pushed the pr-blheli-passthru-fixes2 branch from c76b548 to af2650a Compare March 30, 2025 19:58
@robustini
Copy link
Contributor

robustini commented Mar 31, 2025

Compiled and tested now, no problems found with both AM32 ESC configurators, online and offline.
Written firmware, read written parameters, @andyp1per you did a great job.
I would say the problem is solved.
Tested on Matek H743 WING and single ESC.
I did not venture to try to rewrite the bootloader because this SEQURE SQESC 28120 ESC has the recovery pins covered with resin, and if it failed it would be a problem.

@rmackay9 rmackay9 mentioned this pull request Mar 31, 2025
65 tasks
@andyp1per andyp1per force-pushed the pr-blheli-passthru-fixes2 branch from 60a5af4 to 4a42823 Compare April 1, 2025 08:57
@andyp1per andyp1per requested a review from peterbarker April 1, 2025 08:58
@tridge tridge self-requested a review April 2, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants