-
Notifications
You must be signed in to change notification settings - Fork 18.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_HAL_Chibios:add hwdef files for PixSurveyA2-IND #29662
base: master
Are you sure you want to change the base?
AP_HAL_Chibios:add hwdef files for PixSurveyA2-IND #29662
Conversation
@Hwurzburg @andyp1per request reviews. |
382dc0d
to
0109ba3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some changes/additions to the readme to better match hwdef and allow easy move to wiki when time comes...
Also, the Battery monitor setup is confusing and questionable...you should setup only one monitor by default BATT_MONITOR....it can be analog or CAN, but you need to decide which...the readme will need changing as well as the hwdef when you decide.
Finally, I think @andyp1per may have an issue with the hwdef BIDIR tags
In PixSurveyA2-IND, usually we will access two PMUs, the first one is CAN PMU and the second one is analog PMU. Do you mean why there are two Battery monitors in hwdef? Because we want to be compatible with the customers of PixSurvey A1-IND, because the carrier board of PixSurvey A1-IND only has two analog interfaces, so whether A1 or A2, they can use the carrier board with each other. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so if plugged into old carrier board, which pins go to PWR1 and which to PWR2
and in new carrier bd, which set of analog pins go to the PWR2 ADC connector?
Thank you very much. I have read your email carefully. You're right. I've corrected it. Now BATT1 uses CAN and BATT2 uses analog. |
9f47557
to
32a8989
Compare
32a8989
to
e8e4b18
Compare
@mikefenghao I have cleaned up some things, and pushed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you approve of the changes I made, I will mark for Devcall and merge
I agree. |
add hwdef files for PixSurveyA2-IND.
makeflyeasy has done several tests on PixSurveyA2-IND and works well.
We tested it using a STRIVER mini aircraft, both autonomously and manually violently flown.