Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_HAL_Chibios:add hwdef files for PixSurveyA2-IND #29662

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mikefenghao
Copy link
Contributor

add hwdef files for PixSurveyA2-IND.
makeflyeasy has done several tests on PixSurveyA2-IND and works well.
We tested it using a STRIVER mini aircraft, both autonomously and manually violently flown.

@mikefenghao
Copy link
Contributor Author

@Hwurzburg @andyp1per request reviews.

@Hwurzburg Hwurzburg requested review from andyp1per and Hwurzburg April 1, 2025 12:50
@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label Apr 1, 2025
@Hwurzburg Hwurzburg force-pushed the ardupilot-PixSuevryA2-IND-hwdef branch 2 times, most recently from 382dc0d to 0109ba3 Compare April 2, 2025 19:16
Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some changes/additions to the readme to better match hwdef and allow easy move to wiki when time comes...

Also, the Battery monitor setup is confusing and questionable...you should setup only one monitor by default BATT_MONITOR....it can be analog or CAN, but you need to decide which...the readme will need changing as well as the hwdef when you decide.

Finally, I think @andyp1per may have an issue with the hwdef BIDIR tags

@mikefenghao
Copy link
Contributor Author

I made some changes/additions to the readme to better match hwdef and allow easy move to wiki when time comes...

Also, the Battery monitor setup is confusing and questionable...you should setup only one monitor by default BATT_MONITOR....it can be analog or CAN, but you need to decide which...the readme will need changing as well as the hwdef when you decide.

Finally, I think @andyp1per may have an issue with the hwdef BIDIR tags

In PixSurveyA2-IND, usually we will access two PMUs, the first one is CAN PMU and the second one is analog PMU. Do you mean why there are two Battery monitors in hwdef? Because we want to be compatible with the customers of PixSurvey A1-IND, because the carrier board of PixSurvey A1-IND only has two analog interfaces, so whether A1 or A2, they can use the carrier board with each other.

Copy link
Collaborator

@andyp1per andyp1per left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct

Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so if plugged into old carrier board, which pins go to PWR1 and which to PWR2
and in new carrier bd, which set of analog pins go to the PWR2 ADC connector?

@Hwurzburg Hwurzburg dismissed their stale review April 3, 2025 13:36

need more study before review complete

@Hwurzburg Hwurzburg self-requested a review April 3, 2025 13:36
@mikefenghao
Copy link
Contributor Author

so if plugged into old carrier board, which pins go to PWR1 and which to PWR2 and in new carrier bd, which set of analog pins go to the PWR2 ADC connector?

Thank you very much. I have read your email carefully. You're right. I've corrected it. Now BATT1 uses CAN and BATT2 uses analog.

@Hwurzburg Hwurzburg force-pushed the ardupilot-PixSuevryA2-IND-hwdef branch from 9f47557 to 32a8989 Compare April 7, 2025 15:21
@Hwurzburg Hwurzburg force-pushed the ardupilot-PixSuevryA2-IND-hwdef branch from 32a8989 to e8e4b18 Compare April 7, 2025 15:29
@Hwurzburg
Copy link
Collaborator

@mikefenghao I have cleaned up some things, and pushed:

  • removed changes to A1 readme...should be a separate PR
  • removed module changes included
  • cleaned up board_types
  • reformatted and added to README so conversion to wiki page in the future is easier
    which brings up a question....so far we have not added PixSurvey autopilots to the wiki assuming they are only used in turnkey systems...if this is not correct and you sell some to non MFE vehicle users, we should add them to the wiki...might take a while, though, since the READMEs were not reviewed by me for inclusion in the wiki and will need additional work to create the page...

Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you approve of the changes I made, I will mark for Devcall and merge

@mikefenghao
Copy link
Contributor Author

if you approve of the changes I made, I will mark for Devcall and merge

I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants