[14.0][IMP/ADD] stock_product_variant_mto, sale_stock_mto_as_mts_orderpoint_product_variant: Handle mto route at variant level #1461

mmequignon · 2023-12-22T12:06:20Z

I have to move commits in dedicated PRs, but pushed everything here for the time being

mto_route_product_variant/__manifest__.py

mto_route_product_variant/models/product_product.py

mto_route_product_variant/__manifest__.py

grindtildeath

I'm wondering if the issue at hand couldn't be solved by redefining route_ids as a computed field on product.product and then select the MTO route in the compute function only if the is_mto field is marked?

Maybe we should discuss this together.

sale_stock_mto_as_mts_orderpoint_product_variant/__manifest__.py

mto_route_product_variant/__manifest__.py

mto_route_product_variant/models/product_product.py

mto_route_product_variant/models/product_template.py

mto_route_product_variant/models/product_product.py

grindtildeath · 2024-01-22T16:03:35Z

stock_product_variant_mto/models/product_template.py

+    @api.onchange("route_ids")
+    def onchange_route_ids(self):
+        mto_route = self.env.ref("stock.route_warehouse0_mto", raise_if_not_found=False)
+        if mto_route not in self._origin.route_ids and mto_route in self.route_ids._origin:


I guess we can make the condition more selective and raise the warning only if we have multiple variants, and these variants have different MTO settings.

grindtildeath · 2024-01-22T16:03:42Z

stock_product_variant_mto/models/product_template.py

+                    "message": _("Activating MTO route will reset `Variant is MTO` setting on the variants.")
+                }
+            }
+        if mto_route in self._origin.route_ids and mto_route not in self.route_ids._origin:


Same as above

simahawk · 2024-01-23T11:05:38Z

stock_product_variant_mto/models/product_template.py

+        templates_mto_after = self.filtered(lambda t: mto_route in t.route_ids)
+        templates_mto_added = template_not_mto_before & templates_mto_after
+        templates_mto_removed = (self - template_not_mto_before) & (self - templates_mto_after)
+        (templates_mto_added | templates_mto_removed).product_variant_ids._compute_is_mto()


return res missing

github-actions · 2024-08-18T12:38:21Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

simahawk · 2024-09-23T09:06:52Z

@mmequignon to be reopened?

mmequignon · 2024-09-23T09:23:37Z

@mmequignon to be reopened?

yes please

Define route_ids as computed on the product variant, in order to reuse route_ids from its template and add or remove MTO route according to the setting on the variant. In case MTO route is changed on the template, it must reset any variant specific setting.

jbaudoux · 2025-01-29T08:55:52Z

sale_stock_mto_as_mts_orderpoint_product_variant/models/product_product.py

+        self.ensure_one()
+        return self.is_mto
+
+    def _inverse_is_mto(self):


Where is this defined on the field? I don't think this is called.
Check you have a unit test for this (archiving orderpoint when variant is not MTO anymore)

mmequignon · 2025-02-10T12:58:14Z

I'll rollback @grindtildeath changes as it doesn't work.
Saving a backup with current code here https://github.com/camptocamp/stock-logistics-workflow/tree/handle_mto_route_at_variant_level_backup

mmequignon · 2025-02-10T13:00:40Z

For reviewers, I know a test is failing, this is because in sale_stock_mto_as_mts_orderpoint mto products are enabled/disabled differently. I have to modify this, but feature works, tested from the ui.

There were multiple issues: - Inverse function on storable field is not reliable and we should prefer overriding write to add any processing when the field value is changed. Moreover, the field is_mto on product.product did not have its inverse function set on the field, so the function was not called. - When mto_as_mts is changed on the warehouse, we do not want to archive MTO rule for this warehouse (because we could still want to do MTO but not "as MTS").

henrybackman

Looks good 👍

henrybackman · 2025-02-11T09:51:56Z

sale_stock_mto_as_mts_orderpoint_product_variant/__manifest__.py

@@ -0,0 +1,19 @@
+# Copyright 2024 Camptocamp SA


Inconsistent years

Suggested change

# Copyright 2024 Camptocamp SA

# Copyright 2025 Camptocamp SA

henrybackman · 2025-02-11T09:52:16Z

sale_stock_mto_as_mts_orderpoint_product_variant/models/product_product.py

@@ -0,0 +1,39 @@
+# Copyright 2023 Camptocamp SA


Suggested change

# Copyright 2023 Camptocamp SA

# Copyright 2025 Camptocamp SA

henrybackman · 2025-02-11T09:53:14Z

sale_stock_mto_as_mts_orderpoint_product_variant/models/product_product.py

+        return res
+
+    def _get_orderpoints_to_archive_domain(self, warehouse):
+        # Orderpoints to archive are those where


Incomplete comment?

henrybackman · 2025-02-11T09:54:22Z

sale_stock_mto_as_mts_orderpoint_product_variant/tests/test_mto_as_mts_variant.py

@@ -0,0 +1,155 @@
+# Copyright 2023 Camptocamp SA


Suggested change

# Copyright 2023 Camptocamp SA

# Copyright 2025 Camptocamp SA

henrybackman · 2025-02-11T09:57:26Z

stock_product_variant_mto/__manifest__.py

@@ -0,0 +1,18 @@
+# Copyright 2023 Camptocamp SA


Suggested change

# Copyright 2023 Camptocamp SA

# Copyright 2025 Camptocamp SA

henrybackman · 2025-02-11T09:58:22Z

stock_product_variant_mto/models/product_product.py

+
+IS_MTO_HELP = """
+    Check or Uncheck this field to enable the Make To Order on the variant,
+    independantly from its template configuration.\n


Suggested change

independantly from its template configuration.\n

independently from its template configuration.\n

henrybackman · 2025-02-11T10:07:03Z

stock_product_variant_mto/models/product_template.py

@@ -0,0 +1,44 @@
+# Copyright 2023 Camptocamp SA


Suggested change

# Copyright 2023 Camptocamp SA

# Copyright 2025 Camptocamp SA

henrybackman · 2025-02-11T10:08:56Z

stock_product_variant_mto/tests/common.py

@@ -0,0 +1,80 @@
+# Copyright 2023 Camptocamp SA


Suggested change

# Copyright 2023 Camptocamp SA

# Copyright 2025 Camptocamp SA

henrybackman · 2025-02-11T10:09:13Z

stock_product_variant_mto/tests/test_mto_variant.py

@@ -0,0 +1,108 @@
+# Copyright 2023 Camptocamp SA


Suggested change

# Copyright 2023 Camptocamp SA

# Copyright 2025 Camptocamp SA

henrybackman · 2025-02-11T10:09:53Z

stock_product_variant_mto/views/product_product.xml

@@ -0,0 +1,32 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2023 Camptocamp SA


Suggested change

<!-- Copyright 2023 Camptocamp SA

<!-- Copyright 2025 Camptocamp SA

TDu · 2025-02-11T10:36:52Z

stock_product_variant_mto/models/product_product.py

+        help=IS_MTO_HELP,
+    )
+
+    route_ids = fields.Many2many(


If find having this field on product.product for handling the feature of this module worrisome and could be conflicting with other modules or implementation...

mmequignon force-pushed the handle_mto_route_at_variant_level branch from e394efc to 4cccd24 Compare December 22, 2023 12:10

sebalix reviewed Jan 8, 2024

View reviewed changes

grindtildeath reviewed Jan 8, 2024

View reviewed changes

mmequignon force-pushed the handle_mto_route_at_variant_level branch 2 times, most recently from 5badb3f to e694809 Compare January 9, 2024 10:26

grindtildeath reviewed Jan 22, 2024

View reviewed changes

simahawk reviewed Jan 23, 2024

View reviewed changes

mmequignon force-pushed the handle_mto_route_at_variant_level branch from f4bc814 to 6d7b34d Compare January 24, 2024 09:53

sebalix changed the title ~~[14.0][IMP/ADD] Handle mto route at variant level~~ [14.0][IMP/ADD] stock_product_variant_mto, sale_stock_mto_as_mts_orderpoint_product_variant: Handle mto route at variant level Apr 19, 2024

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 18, 2024

github-actions bot closed this Sep 22, 2024

simahawk reopened this Sep 23, 2024

simahawk removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 23, 2024

mmequignon and others added 5 commits October 11, 2024 15:14

sale_stock_mto_as_mts_orderpoint: Add hooks

d75564e

Add mto_route_product_variant

deef52a

Add sale_stock_mto_as_mts_orderpoint_product_variant

8b6a7de

fixup! Refactor mto_route_product_variant

d634638

mmequignon force-pushed the handle_mto_route_at_variant_level branch from 6d7b34d to d634638 Compare October 11, 2024 13:15

This was referenced Jan 2, 2025

[18.0][MIG] stock_product_variant_mto: Migration to 18.0 chaule97/stock-logistics-workflow#1

Open

[18.0][MIG] stock_product_variant_mto: Migration to 18.0 #1819

Closed

This was referenced Jan 9, 2025

[18.0][MIG] sale_stock_mto_as_mts_orderpoint_product_variant: Migration to 18.0 chaule97/stock-logistics-workflow#3

Open

[18.0][MIG] sale_stock_mto_as_mts_orderpoint_product_variant: Migration to 18.0 OCA/stock-logistics-orderpoint#29

Draft

jbaudoux requested changes Jan 29, 2025

View reviewed changes

chaule97 mentioned this pull request Feb 6, 2025

[18.0][MIG] product_variant_route_mto: Migration to 18.0 OCA/product-attribute#1879

Open

mmequignon force-pushed the handle_mto_route_at_variant_level branch from d634638 to bc17928 Compare February 10, 2025 12:58

grindtildeath force-pushed the handle_mto_route_at_variant_level branch from bc17928 to 4ed01c0 Compare February 10, 2025 19:53

grindtildeath force-pushed the handle_mto_route_at_variant_level branch from 4ed01c0 to 3d81b69 Compare February 10, 2025 19:57

henrybackman approved these changes Feb 11, 2025

View reviewed changes

TDu reviewed Feb 11, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0][IMP/ADD] stock_product_variant_mto, sale_stock_mto_as_mts_orderpoint_product_variant: Handle mto route at variant level #1461

[14.0][IMP/ADD] stock_product_variant_mto, sale_stock_mto_as_mts_orderpoint_product_variant: Handle mto route at variant level #1461

mmequignon commented Dec 22, 2023

grindtildeath left a comment

grindtildeath Jan 22, 2024

grindtildeath Jan 22, 2024

simahawk Jan 23, 2024

github-actions bot commented Aug 18, 2024

simahawk commented Sep 23, 2024

mmequignon commented Sep 23, 2024

jbaudoux Jan 29, 2025

mmequignon commented Feb 10, 2025

mmequignon commented Feb 10, 2025

henrybackman left a comment

henrybackman Feb 11, 2025

henrybackman Feb 11, 2025

henrybackman Feb 11, 2025

henrybackman Feb 11, 2025

henrybackman Feb 11, 2025

henrybackman Feb 11, 2025

henrybackman Feb 11, 2025

henrybackman Feb 11, 2025

henrybackman Feb 11, 2025

henrybackman Feb 11, 2025

TDu Feb 11, 2025 •

edited

Loading

	# Copyright 2024 Camptocamp SA
	# Copyright 2025 Camptocamp SA

	# Copyright 2023 Camptocamp SA
	# Copyright 2025 Camptocamp SA

	independantly from its template configuration.\n
	independently from its template configuration.\n

		@@ -0,0 +1,32 @@
		<?xml version="1.0" encoding="utf-8"?>
		<!-- Copyright 2023 Camptocamp SA

	<!-- Copyright 2023 Camptocamp SA
	<!-- Copyright 2025 Camptocamp SA

[14.0][IMP/ADD] stock_product_variant_mto, sale_stock_mto_as_mts_orderpoint_product_variant: Handle mto route at variant level #1461

Are you sure you want to change the base?

[14.0][IMP/ADD] stock_product_variant_mto, sale_stock_mto_as_mts_orderpoint_product_variant: Handle mto route at variant level #1461

Conversation

mmequignon commented Dec 22, 2023

grindtildeath left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Aug 18, 2024

simahawk commented Sep 23, 2024

mmequignon commented Sep 23, 2024

Choose a reason for hiding this comment

mmequignon commented Feb 10, 2025

mmequignon commented Feb 10, 2025

henrybackman left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TDu Feb 11, 2025 • edited Loading

Choose a reason for hiding this comment

TDu Feb 11, 2025 •

edited

Loading