-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: Add unit for actuator slew rate and reword description #23846
base: main
Are you sure you want to change the base?
Conversation
the full output range. A value x means that the servo signal | ||
can only go from -1 to 1 in minimum x seconds. | ||
Forces the servo output signal to take at least the configured time (in seconds) | ||
to traverse its full range [-100%, 100%]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the range of a servo defined from -1 to 1? I.e. can a servo be defined to have a range of 0 - 100%? If it can, I'd be tempted to remove the [-100%, 100%]
.
I ask because a while a rudder (say) moves about a neutral centre position, a flap moves from a neutral position to full extension. Now I think that for flaps the movement is always 0 - 1 but you can set zero to be half way across the servo PWM output range or at the lowest value.
That's all a bit confusing - I guess I'm saying, is it the time for moving neutral to full for a rudder?
Also, as above range [-1,1] is consistent with other docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the actuator doc example "They also have a slew rate of 0.5/s, meaning that it will take 2s to fully deflect them (a slew rate on the flaps is generally recommended to reduce the disturbances their movement creates)."
So I think this is from 0 to 1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually don't know and would need to check in code. Likely @sfuhrer knows by heart and in case it's not super clear certainly how it should be.
Added some comments. Docs should not be too hard |
…ew rate description Co-authored-by: Hamish Willee <[email protected]>
Solved Problem
When resolving my oversight here #23835 (comment) I took over the parameter description I came up with.
Changelog Entry