Skip to content

Glam 0.31 #22681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alice-i-cecile merged 6 commits into from
Jan 25, 2026
Merged

Glam 0.31 #22681

alice-i-cecile merged 6 commits into from
Jan 25, 2026
+48 −55

Conversation

@hukasu
Copy link
Contributor

@hukasu hukasu commented Jan 24, 2026 •
edited
Loading

Objective

Adopt and closes #22665

Solution

Delete bevy's Affine3, create an extension trait for methods create for old bevy's Affine3 to be used by glam's Affine3, and register glam's Affine3 for reflection

Testing

cargo run -p ci

dependabot bot and others added 3 commits January 23, 2026 07:08
@dependabot
Update glam requirement from 0.30.7 to 0.31.0
d01c906 
Updates the requirements on [glam](https://github.com/bitshifter/glam-rs) to permit the latest version.
- [Changelog](https://github.com/bitshifter/glam-rs/blob/main/CHANGELOG.md)
- [Commits](https://github.com/bitshifter/glam-rs/commits)

---
updated-dependencies:
- dependency-name: glam
  dependency-version: 0.31.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@hukasu
Replace Bevy's Affine3 for glam's, create an extension trait for be…
ea91752 
…vy specific methods
@hukasu
Reflect glam's Affine3
2ddab24
@hukasu hukasu added A-Math Fundamental domain-agnostic mathematical operations M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 24, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2026

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Please review the instructions for writing migration guides, then expand or revise the content in the migration guides directory to reflect your changes.

@hukasu hukasu marked this pull request as ready for review January 24, 2026 14:57
@hukasu
Copy link
Contributor Author

hukasu commented Jan 24, 2026

Glam dependency duplicated on hexaspehere and dlss_wgpu

@hukasu
Copy link
Contributor Author

hukasu commented Jan 24, 2026

created a PR on hexasphere OptimisticPeach/hexasphere#40

@OptimisticPeach
Copy link
Contributor

OptimisticPeach commented Jan 24, 2026 •
edited
Loading

Hexasphere v16.1.0 is out and can use glam 0.31.0.

Hexasphere v17.0.0 is out and uses glam 0.31.0.

(See here as for why the edit was made.)

@mockersf
Copy link
Member

mockersf commented Jan 25, 2026

I would prefer to remove glam from dlss_wgpu instead of having to release a major version of it with each update: bevyengine/dlss_wgpu#19

@alice-i-cecile alice-i-cecile added this to the 0.19 milestone Jan 25, 2026
alice-i-cecile
alice-i-cecile approved these changes Jan 25, 2026
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good migration guide, good update. I've merged the PR in dlss_wgpu to remove the glam dependency; we'll pick that up in the next release.

@alice-i-cecile alice-i-cecile added C-Dependencies A change to the crates that Bevy depends on S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 25, 2026
@hukasu
Copy link
Contributor Author

hukasu commented Jan 25, 2026

is it fine merging with the ban still breaking?

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 25, 2026
Merged via the queue into bevyengine:main with commit abbaa47 Jan 25, 2026
45 of 46 checks passed
@hukasu hukasu deleted the glam-0.31 branch January 25, 2026 22:41
@alice-i-cecile alice-i-cecile mentioned this pull request Jan 26, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

Assignees

No one assigned

Labels

A-Math Fundamental domain-agnostic mathematical operations C-Dependencies A change to the crates that Bevy depends on M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

0.19

Development

Successfully merging this pull request may close these issues.

4 participants

@hukasu @OptimisticPeach @mockersf @alice-i-cecile